hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-1948) S3 MPU can't be created with octet-stream content-type
Date Fri, 23 Aug 2019 06:16:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-1948?focusedWorklogId=300071&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-300071

ASF GitHub Bot logged work on HDDS-1948:

                Author: ASF GitHub Bot
            Created on: 23/Aug/19 06:15
            Start Date: 23/Aug/19 06:15
    Worklog Time Spent: 10m 
      Work Description: bharatviswa504 commented on pull request #1266: HDDS-1948. S3 MPU
can't be created with octet-stream content-type 
URL: https://github.com/apache/hadoop/pull/1266#discussion_r316986612

 File path: hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/HeaderPreprocessor.java
 @@ -17,39 +17,58 @@
 package org.apache.hadoop.ozone.s3;
+import javax.annotation.Priority;
 import javax.ws.rs.container.ContainerRequestContext;
 import javax.ws.rs.container.ContainerRequestFilter;
 import javax.ws.rs.container.PreMatching;
 import javax.ws.rs.core.MediaType;
+import javax.ws.rs.core.MultivaluedMap;
 import javax.ws.rs.ext.Provider;
 import java.io.IOException;
  * Filter to adjust request headers for compatible reasons.
+ *
+ * It should be executed AFTER signature check (VirtualHostStyleFilter).
 Review comment:
   This approach LGTM, clear to understand.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 300071)
    Time Spent: 2.5h  (was: 2h 20m)

> S3 MPU can't be created with octet-stream content-type 
> -------------------------------------------------------
>                 Key: HDDS-1948
>                 URL: https://issues.apache.org/jira/browse/HDDS-1948
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: S3
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.5.0
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
> This problem is reported offline by [~shanekumpf@gmail.com].
> When aws-sdk-go is used to access to s3 gateway of Ozone it sends the Multi Part Upload
initialize message with "application/octet-stream" Content-Type. 
> This Content-Type is missing from the aws-cli which is used to reimplement s3 endpoint.
> The problem is that we use the same rest endpoint for initialize and complete Multipart
Upload request. For the completion we need the CompleteMultipartUploadRequest parameter which
is parsed from the body.
> For initialize we have an empty body which can't be serialized to CompleteMultipartUploadRequest.
> The workaround is to set a specific content type from a filter which help up to create
two different REST method for initialize and completion message.
> Here is an example to test (using bogus AWS credentials).
> {code}
> curl -H 'Host:yourhost' -H 'User-Agent:aws-sdk-go/1.15.11 (go1.11.2; linux; amd64)' -H
'Content-Length:0' -H 'Authorization:AWS4-HMAC-SHA256 Credential=qwe/20190809/ozone/s3/aws4_request,
Signature=7726ed63990ba3f4f1f796d4ab263f5d9c3374528840f5e49d106dbef491f22c' -H 'Content-Type:application/octet-stream'
-H 'X-Amz-Acl:private' -H 'X-Amz-Content-Sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855'
-H 'X-Amz-Date:20190809T070142Z' -H 'X-Amz-Storage-Class:STANDARD' -H 'Accept-Encoding:gzip'
-X POST 'http://localhost:9999/docker/docker/registry/v2/repositories/apache/ozone-runner/_uploads/2173f019-09c3-466b-bb7d-c31ce749d826/data?uploads
> {code}
> Without the patch it returns with HTTP 405 (Not supported Media Type).

This message was sent by Atlassian Jira

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message