hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Íñigo Goiri (JIRA) <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-14713) RBF: routeradmin support refreshRouterArgs command but it not on display
Date Mon, 12 Aug 2019 16:28:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-14713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905352#comment-16905352
] 

Íñigo Goiri edited comment on HDFS-14713 at 8/12/19 4:27 PM:
-------------------------------------------------------------

[^HDFS-14713-001.patch] LGTM.
We may want to make the test a little more generic and make it to test the full help message
to verify the whole string is there.


was (Author: elgoiri):
[^HDFS-14713-001.patch] LGTM.
+1

> RBF: routeradmin support refreshRouterArgs command but it not on display
> ------------------------------------------------------------------------
>
>                 Key: HDFS-14713
>                 URL: https://issues.apache.org/jira/browse/HDFS-14713
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: wangzhaohui
>            Assignee: wangzhaohui
>            Priority: Major
>         Attachments: HDFS-14713-000.patch, HDFS-14713-001.patch, after.png, before.png
>
>
> When the cmd commond is null,the refreshRouterArgs command is not display ,because there
is one missing value in the String[] commands
> {code:java}
> //
> if (cmd == null) {
>   String[] commands =
>       {"-add", "-update", "-rm", "-ls", "-getDestination",
>           "-setQuota", "-clrQuota",
>           "-safemode", "-nameservice", "-getDisabledNameservices",
>           "-refresh"};
>   StringBuilder usage = new StringBuilder();
>   usage.append("Usage: hdfs dfsrouteradmin :\n");
>   for (int i = 0; i < commands.length; i++) {
>     usage.append(getUsage(commands[i]));
>     if (i + 1 < commands.length) {
>       usage.append("\n");
>     }
>   }
>   ....
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message