hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-1927) Consolidate add/remove Acl into OzoneAclUtil class
Date Thu, 15 Aug 2019 18:16:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-1927?focusedWorklogId=295639&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295639

ASF GitHub Bot logged work on HDDS-1927:

                Author: ASF GitHub Bot
            Created on: 15/Aug/19 18:15
            Start Date: 15/Aug/19 18:15
    Worklog Time Spent: 10m 
      Work Description: anuengineer commented on issue #1263: HDDS-1927. Consolidate add/remove
Acl into OzoneAclUtil class. Contri…
URL: https://github.com/apache/hadoop/pull/1263#issuecomment-521741875
   I am +1 on these changes, and thanks for fixing the Findbugs issue. Can you please rebase
and post a new patch. I will go ahead and commit it then. @bharatviswa504 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 295639)
    Time Spent: 2h 10m  (was: 2h)

> Consolidate add/remove Acl into OzoneAclUtil class
> --------------------------------------------------
>                 Key: HDDS-1927
>                 URL: https://issues.apache.org/jira/browse/HDDS-1927
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>            Reporter: Bharat Viswanadham
>            Assignee: Xiaoyu Yao
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
> This Jira is created based on @xiaoyu comment on HDDS-1884
> Can we abstract these add/remove logic into common AclUtil class as we can see similar
logic in both bucket manager and key manager? For example,
> public static boolean addAcl(List existingAcls, OzoneAcl newAcl)
> public static boolean removeAcl(List existingAcls, OzoneAcl newAcl)
> But to do this, we need both OmKeyInfo and OMBucketInfo to use list of OzoneAcl/OzoneAclInfo.
> This Jira is to do that refactor, and also address above comment to move common logic
to AclUtils.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message