hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-1913) Fix OzoneBucket and RpcClient APIS for acl
Date Fri, 09 Aug 2019 18:24:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-1913?focusedWorklogId=292208&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292208
]

ASF GitHub Bot logged work on HDDS-1913:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Aug/19 18:23
            Start Date: 09/Aug/19 18:23
    Worklog Time Spent: 10m 
      Work Description: bharatviswa504 commented on pull request #1257: HDDS-1913. Fix OzoneBucket
and RpcClient APIS for acl.
URL: https://github.com/apache/hadoop/pull/1257#discussion_r312597784
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManagerImpl.java
 ##########
 @@ -272,16 +272,6 @@ public void setBucketProperty(OmBucketArgs args) throws IOException
{
           .setBucketName(oldBucketInfo.getBucketName());
       bucketInfoBuilder.addAllMetadata(args.getMetadata());
 
-      //Check ACLs to update
-      if (args.getAddAcls() != null || args.getRemoveAcls() != null) {
-        bucketInfoBuilder.setAcls(getUpdatedAclList(oldBucketInfo.getAcls(),
-            args.getRemoveAcls(), args.getAddAcls()));
-        LOG.debug("Updating ACLs for bucket: {} in volume: {}",
-            bucketName, volumeName);
-      } else {
-        bucketInfoBuilder.setAcls(oldBucketInfo.getAcls());
 
 Review comment:
   Thanks for catching fixed it, and also added a test to cover this scenario.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 292208)
    Time Spent: 40m  (was: 0.5h)

> Fix OzoneBucket and RpcClient APIS for acl
> ------------------------------------------
>
>                 Key: HDDS-1913
>                 URL: https://issues.apache.org/jira/browse/HDDS-1913
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Blocker
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Fix addAcl,removeAcl in OzoneBucket to use newly added acl API's addAcl/removeAcl as
part of HDDS-1739.
> Remove addBucketAcls, removeBucketAcls from RpcClient. We should use addAcl/removeAcl.
>  
> And also fix @xiaoyu comment on HDDS-1900 jira. BucketManagerImpl#setBucketProperty()
as they now require a different permission (WRITE_ACL instead of WRITE)?



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message