hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-1909) Use new HA code for Non-HA in OM
Date Fri, 30 Aug 2019 18:02:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-1909?focusedWorklogId=304467&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-304467
]

ASF GitHub Bot logged work on HDDS-1909:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/Aug/19 18:01
            Start Date: 30/Aug/19 18:01
    Worklog Time Spent: 10m 
      Work Description: bharatviswa504 commented on pull request #1225: HDDS-1909. Use new
HA code for Non-HA in OM.
URL: https://github.com/apache/hadoop/pull/1225#discussion_r319620120
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestS3BucketManager.java
 ##########
 @@ -135,29 +99,17 @@ public void testGetS3BucketMapping() throws IOException {
   public void testGetOzoneNames() throws IOException {
     S3BucketManager s3BucketManager = new S3BucketManagerImpl(conf, metaMgr,
         volumeManager, bucketManager);
-    s3BucketManager.createOzoneVolumeIfNeeded("batman");
-    s3BucketManager.createS3Bucket("batman", "gotham");
-    String volumeName = s3BucketManager.getOzoneVolumeName("gotham");
-    Assert.assertTrue(volumeName.equalsIgnoreCase("s3batman"));
-    String bucketName =s3BucketManager.getOzoneBucketName("gotham");
-    Assert.assertTrue(bucketName.equalsIgnoreCase("gotham"));
+    String userName = "batman";
+    String s3BucketName = "gotham";
+    metaMgr.getS3Table().put(s3BucketName,
+        s3BucketManager.formatOzoneVolumeName(userName) + "/" + s3BucketName);
+    String volumeName = s3BucketManager.getOzoneVolumeName(s3BucketName);
+    Assert.assertTrue(volumeName.equalsIgnoreCase("s3"+userName));
+    String bucketName =s3BucketManager.getOzoneBucketName(s3BucketName);
+    Assert.assertTrue(bucketName.equalsIgnoreCase(s3BucketName));
     // try to get a bucket that does not exist.
     thrown.expectMessage("No such S3 bucket.");
     s3BucketManager.getOzoneBucketMapping("raven");
 
   }
-
-  @Test
-  /**
-   * This tests makes sure bucket names are unique across users.
-   */
-  public void testBucketNameAreUnique() throws IOException {
 
 Review comment:
   Same as above this code path will not be used and also there are tests added in TestS3BucketCreateRequest.java
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 304467)
    Time Spent: 13h 20m  (was: 13h 10m)

> Use new HA code for Non-HA in OM
> --------------------------------
>
>                 Key: HDDS-1909
>                 URL: https://issues.apache.org/jira/browse/HDDS-1909
>             Project: Hadoop Distributed Data Store
>          Issue Type: New Feature
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 13h 20m
>  Remaining Estimate: 0h
>
> This Jira is to use new HA code of OM in Non-HA code path.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message