hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Masatake Iwasaki (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-14423) Percent (%) and plus (+) characters no longer work in WebHDFS
Date Mon, 12 Aug 2019 07:31:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-14423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904926#comment-16904926
] 

Masatake Iwasaki commented on HDFS-14423:
-----------------------------------------

{quote}client deubg log shows expected URL in which "+" is not converted.

$ bin/hdfs dfs -touchz 'webhdfs://localhost/a+b'
 2019-08-12 09:10:04,929 TRACE web.WebHdfsFileSystem: url=[http://localhost:9870/webhdfs/v1/a+b?op=GETFILESTATUS&user.name=iwasakims]
{quote}
I think even this was not so expected result now. Since SPECIAL_FILENAME_CHARACTERS_REGEX
matches to "a+b", is is applied to URLEncoder#encode.
{noformat}
  public static final String SPECIAL_FILENAME_CHARACTERS_REGEX = ".*[;+%].*";
{noformat}
The "+" in the URL is not encoded because "a+b" is converted into "a b" by URLDecoder#decode
first then encoded back into "a+b" by URLEncoder#encode. The code intended for already url-encoded
path elements seems to be working in unintended way.

> Percent (%) and plus (+) characters no longer work in WebHDFS
> -------------------------------------------------------------
>
>                 Key: HDFS-14423
>                 URL: https://issues.apache.org/jira/browse/HDFS-14423
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: webhdfs
>    Affects Versions: 3.2.0, 3.1.2
>         Environment: Ubuntu 16.04, but I believe this is irrelevant.
>            Reporter: Jing Wang
>            Assignee: Wei-Chiu Chuang
>            Priority: Major
>         Attachments: HDFS-14423.001.patch
>
>
> The following commands with percent (%) no longer work starting with version 3.1:
> {code:java}
> $ hadoop/bin/hdfs dfs -touchz webhdfs://localhost/%
> $ hadoop/bin/hdfs dfs -cat webhdfs://localhost/%
> cat: URLDecoder: Incomplete trailing escape (%) pattern
> {code}
> Also, plus (+ ) characters get turned into spaces when doing DN operations:
> {code:java}
> $ hadoop/bin/hdfs dfs -touchz webhdfs://localhost/a+b
> $ hadoop/bin/hdfs dfs -mkdir webhdfs://localhost/c+d
> $ hadoop/bin/hdfs dfs -ls /
> Found 4 items
> -rw-r--r--   1 jing supergroup          0 2019-04-12 11:20 /a b
> drwxr-xr-x   - jing supergroup          0 2019-04-12 11:21 /c+d
> {code}
> I can confirm that these commands work correctly on 2.9 and 3.0. Also, the usual hdfs://
client works as expected.
> I suspect a relation with HDFS-13176 or HDFS-13582, but I'm not sure what the right fix
is. Note that Hive uses % to escape special characters in partition values, so banning % might
not be a good option. For example, Hive will create a paths like {{table_name/partition_key=%2F}}
when {{partition_key='/'}}.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message