hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-1366) Add ability in Recon to track the number of small files in an Ozone cluster.
Date Thu, 08 Aug 2019 23:17:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-1366?focusedWorklogId=291646&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-291646
]

ASF GitHub Bot logged work on HDDS-1366:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Aug/19 23:16
            Start Date: 08/Aug/19 23:16
    Worklog Time Spent: 10m 
      Work Description: avijayanhwx commented on pull request #1146: HDDS-1366. Add ability
in Recon to track the number of small files in an Ozone Cluster
URL: https://github.com/apache/hadoop/pull/1146#discussion_r312278997
 
 

 ##########
 File path: hadoop-ozone/ozone-recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestUtilizationService.java
 ##########
 @@ -62,66 +64,73 @@ public void setUpResultList() {
             (long) i));
       }
     }
+    return resultList;
   }
 
   @Test
   public void testGetFileCounts() throws IOException {
-    setUpResultList();
+    List<FileCountBySize> resultList = setUpResultList();
 
     utilizationService = mock(UtilizationService.class);
     when(utilizationService.getFileCounts()).thenCallRealMethod();
     when(utilizationService.getDao()).thenReturn(fileCountBySizeDao);
     when(fileCountBySizeDao.findAll()).thenReturn(resultList);
 
-    utilizationService.getFileCounts();
+    Response response = utilizationService.getFileCounts();
+    // get result list from Response entity
+    List<FileCountBySize> responseList =
+        (List<FileCountBySize>) response.getEntity();
+
     verify(utilizationService, times(1)).getFileCounts();
 
 Review comment:
   Why are we verifying the actual method call? Method calls verification is generally used
for mocked methods (So that we know the code path went through that). 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 291646)
    Time Spent: 10h 20m  (was: 10h 10m)

> Add ability in Recon to track the number of small files in an Ozone cluster.
> ----------------------------------------------------------------------------
>
>                 Key: HDDS-1366
>                 URL: https://issues.apache.org/jira/browse/HDDS-1366
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>          Components: Ozone Recon
>            Reporter: Aravindan Vijayan
>            Assignee: Shweta
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10h 20m
>  Remaining Estimate: 0h
>
> Ozone users may want to track the number of small files they have in their cluster and
where they are present. Recon can help them with the information by iterating the OM Key Table
and dividing the keys into different buckets based on the data size. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message