hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam Antal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-14195) OIV: print out storage policy id in oiv Delimited output
Date Mon, 05 Aug 2019 09:02:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-14195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899917#comment-16899917
] 

Adam Antal commented on HDFS-14195:
-----------------------------------

Thanks for the patch, [~suxingfate].
 It is structurally correct, nice job!

One last item is some checkstyle issues:
 - Some long >80 lines and unused imports, please check [logs|https://builds.apache.org/job/PreCommit-HDFS-Build/27382/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt]
on jenkins.
 - There are also a few missing whitespaces before and after the condition here:
{noformat}
if(writer.printStoragePolicy){
  writer.append(buffer, storagePolicy);
}
{noformat}
and here in {{PBImageDelimitedTextWriter.java}}:
{noformat}
if(printStoragePolicy){
  append(buffer, "StoragePolicyId");
}
{noformat}
and in {{PBImageTextWriter.java}}:
{noformat}
for(XAttr xattr : xattrs){
  if (BlockStoragePolicySuite.isStoragePolicyXAttr(xattr)) {
    return xattr.getValue()[0];
  }
}
{noformat}

Otherwise it's a +1 (non-binding) from me. 

Could you take a look as well [~jojochuang] to assure we didn't miss anything?

> OIV: print out storage policy id in oiv Delimited output
> --------------------------------------------------------
>
>                 Key: HDFS-14195
>                 URL: https://issues.apache.org/jira/browse/HDFS-14195
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: tools
>            Reporter: Wang, Xinglong
>            Assignee: Wang, Xinglong
>            Priority: Minor
>         Attachments: HDFS-14195.001.patch, HDFS-14195.002.patch, HDFS-14195.003.patch,
HDFS-14195.004.patch, HDFS-14195.005.patch, HDFS-14195.006.patch, HDFS-14195.007.patch, HDFS-14195.008.patch
>
>
> There is lacking of a method to get all folders and files with sort of specified storage
policy via command line, like ALL_SSD type.
> By adding storage policy id to oiv output, it will help with oiv post-analysis to have
a overview of all folders/files with specified storage policy and to apply internal regulation
based on this information.
>  
> Currently, for PBImageXmlWriter.java, in HDFS-9835 it added function to print out xattr
which including storage policy already.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message