From hdfs-issues-return-271196-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Tue Jul 9 20:40:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 64F51180675 for ; Tue, 9 Jul 2019 22:40:04 +0200 (CEST) Received: (qmail 11362 invoked by uid 500); 9 Jul 2019 20:40:02 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 11221 invoked by uid 99); 9 Jul 2019 20:40:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Jul 2019 20:40:02 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8D6C5E2B40 for ; Tue, 9 Jul 2019 20:40:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 88D532657D for ; Tue, 9 Jul 2019 20:40:00 +0000 (UTC) Date: Tue, 9 Jul 2019 20:40:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (HDDS-1775) Make OM KeyDeletingService compatible with HA model MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDDS-1775?focusedWorklogId=274377&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-274377 ] ASF GitHub Bot logged work on HDDS-1775: ---------------------------------------- Author: ASF GitHub Bot Created on: 09/Jul/19 20:39 Start Date: 09/Jul/19 20:39 Worklog Time Spent: 10m Work Description: arp7 commented on pull request #1063: HDDS-1775. Make OM KeyDeletingService compatible with HA model URL: https://github.com/apache/hadoop/pull/1063#discussion_r301778230 ########## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyDeletingService.java ########## @@ -55,17 +58,21 @@ // The thread pool size for key deleting service. private final static int KEY_DELETING_CORE_POOL_SIZE = 2; + private final OzoneManager ozoneManager; private final ScmBlockLocationProtocol scmClient; private final KeyManager manager; + private ClientId clientId = ClientId.randomId(); private final int keyLimitPerTask; private final AtomicLong deletedKeyCount; private final AtomicLong runCount; - public KeyDeletingService(ScmBlockLocationProtocol scmClient, + public KeyDeletingService(OzoneManager ozoneManager, + ScmBlockLocationProtocol scmClient, KeyManager manager, long serviceInterval, long serviceTimeout, Configuration conf) { super("KeyDeletingService", serviceInterval, TimeUnit.MILLISECONDS, KEY_DELETING_CORE_POOL_SIZE, serviceTimeout); + this.ozoneManager = ozoneManager; Review comment: Can you think of a way to avoid passing `OzoneManager` to this class? We now have a low level class depending on a higher level class and potentially a circular dependency. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 274377) Time Spent: 50m (was: 40m) > Make OM KeyDeletingService compatible with HA model > --------------------------------------------------- > > Key: HDDS-1775 > URL: https://issues.apache.org/jira/browse/HDDS-1775 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Reporter: Hanisha Koneru > Assignee: Hanisha Koneru > Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > Currently OM KeyDeletingService directly deletes all the keys in DeletedTable after deleting the corresponding blocks through SCM. For HA compatibility, the key purging should happen through the OM Ratis server. This Jira introduces PurgeKeys request in OM protocol. This request will be submitted to OMs Ratis server after SCM deletes blocks corresponding to deleted keys. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org