From hdfs-issues-return-270498-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Wed Jul 3 19:00:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1FD16180181 for ; Wed, 3 Jul 2019 21:00:02 +0200 (CEST) Received: (qmail 39725 invoked by uid 500); 3 Jul 2019 19:00:01 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 39703 invoked by uid 99); 3 Jul 2019 19:00:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jul 2019 19:00:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7795DE2AD9 for ; Wed, 3 Jul 2019 19:00:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 37F02261F6 for ; Wed, 3 Jul 2019 19:00:00 +0000 (UTC) Date: Wed, 3 Jul 2019 19:00:00 +0000 (UTC) From: "Bharat Viswanadham (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work started] (HDDS-1761) Fix class hierarchy for OMKeyCreateRequest and OMFileCreateRequest MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDDS-1761?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HDDS-1761 started by Bharat Viswanadham. ------------------------------------------------ > Fix class hierarchy for OMKeyCreateRequest and OMFileCreateRequest > ------------------------------------------------------------------ > > Key: HDDS-1761 > URL: https://issues.apache.org/jira/browse/HDDS-1761 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Reporter: Bharat Viswanadham > Assignee: Bharat Viswanadham > Priority: Major > > The patch looks mostly fine to me. A few minor comments.=C2=A0-and one ty= pe error that needs to be fixed.- > I would like to see the class hierarchy refactored in a follow up patch.= =C2=A0{{OMFileCreateRequest}}should not extend=C2=A0{{OMKeyCreateRequest}}.= Instead they should both extend an abstract class that encapsulates the co= mmon functionality. > Generally deriving from=C2=A0_concrete_=C2=A0classes is a bad idea. > =C2=A0 > This Jira is created based on [~arp] comment during review of HDDS-1731 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org