From hdfs-issues-return-270163-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Tue Jul 2 05:31:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4D413180763 for ; Tue, 2 Jul 2019 07:31:05 +0200 (CEST) Received: (qmail 77195 invoked by uid 500); 2 Jul 2019 05:31:03 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 77093 invoked by uid 99); 2 Jul 2019 05:31:03 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jul 2019 05:31:03 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C464AE0DDB for ; Tue, 2 Jul 2019 05:31:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 7E01B261A3 for ; Tue, 2 Jul 2019 05:31:00 +0000 (UTC) Date: Tue, 2 Jul 2019 05:31:00 +0000 (UTC) From: "Anu Engineer (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (HDDS-1735) Create separate unit and integration test executor dev-support script MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDDS-1735?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16876= 671#comment-16876671 ]=20 Anu Engineer edited comment on HDDS-1735 at 7/2/19 5:30 AM: ------------------------------------------------------------ {quote}Look for the section, Testing your patch {quote} It tells how to run Hadoop on my Mac. My question was: {quote}Can you point me to an instruction =E2=80=93 or documentation that e= xplain how to even setup Yetus on my Mac {quote} Completely different question. =C2=A0 {quote}Checkstyle, findbugs, rat plugins, shellcheck, Dockerfile checks are= all using default or relaxed rules sets {quote} You are making assertions without data to back you up. I will personally as= sert what you saying is completely wrong. To the point that I think you hav= e no idea what you are talking about. # Let us do some tests =E2=80=93 Take checkstyle =E2=80=93 run it over Had= oop HDFS and Hadoop Common code base and post the result here. # Now run the same over Ozone and HDDS directory; post the result here. I am sure you will not; since It will just expose your false claim. =C2=A0 Now let us go to findbugs, Do the same =E2=80=93 run the findbugs =E2=80=93= Then be a good citizen in the Hadoop world and fix the issues. I will thro= w my name in the gauntlet, if you can fix 10% of find bugs issues in HDFS/H= adoop Common code base. I will personally fix all find bugs issues in Ozone= / HDDS code base. =C2=A0 Please do not make assertions without knowing what you are talking about. =C2=A0 Before we argue your *opinion* vs my *opinion*; let us measure, I really da= re you to follow up on this; if you cannot please hold you peace forever an= d stop trolling us. =C2=A0 =C2=A0 =C2=A0 =C2=A0 was (Author: anu): {quote}Look for the section, Testing your patch {quote} It tells how to run Hadoop on my Mac. My question was: {quote}Can you point me to an instruction =E2=80=93 or documentation that e= xplain how to even setup Yetus on my Mac {quote} Completely different question. =C2=A0 {quote}Checkstyle, findbugs, rat plugins, shellcheck, Dockerfile checks are= all using default or relaxed rules sets {quote} You are making assertions without data to back you up. I will personally as= sert what you saying is completely wrong. To the point that I think you hav= e no idea what you are talking about. # Let us do some tests =E2=80=93 Take checkstyle =E2=80=93 run it over Had= oop HDFS and Hadoop Common code base and post the result here. # Now run the same over Ozone and HDDS directory; post the result here. I am sure you will not; since It will just expose your false claim. =C2=A0 Now let us go to findbugs, Do the same =E2=80=93 run the findbugs =E2=80=93= Then be a good citizen in the Hadoop world and fix the issues. I will thro= w my name in the gaunlet, if you can fix 10% of find bugs issues in HDFS/Ha= doop Common code base. I will personally fix all find bugs issues in Ozone = / HDDS code base. =C2=A0 Please do not make assertions without knowing what you are talking about. =C2=A0 Before we argue your *opinion* vs my *opinion*; let us measure, I really da= re you to follow up on this; if you cannot please hold you peace forever an= d stop trolling us. =C2=A0 =C2=A0 =C2=A0 =C2=A0 > Create separate unit and integration test executor dev-support script > --------------------------------------------------------------------- > > Key: HDDS-1735 > URL: https://issues.apache.org/jira/browse/HDDS-1735 > Project: Hadoop Distributed Data Store > Issue Type: Improvement > Reporter: Elek, Marton > Assignee: Elek, Marton > Priority: Major > Labels: pull-request-available > Time Spent: 1h 10m > Remaining Estimate: 0h > > hadoop-ozone/dev-support/checks directory contains multiple helper script= to execute different type of testing (findbugs, rat, unit, build). > They easily define how tests should be executed, with the following contr= act: > =C2=A0* The problems should be printed out to the console > =C2=A0* in case of test failure a non zero exit code should be used > =C2=A0 > The tests are working well (in fact I have some experiments with executin= g these scripts on k8s and argo where all the shell scripts are executed pa= rallel) but we need some update: > =C2=A01. Most important: the unit tests and integration tests can be sepa= rated. Integration tests are more flaky and it's better to have a way to ru= n only the normal unit tests > =C2=A02. As HDDS-1115 introduced a pom.ozone.xml it's better to use them = instead of the magical "am pl hadoop-ozone-dist" trick-- > =C2=A03. To make it possible to run blockade test in containers we should= use - T flag with docker-compose > =C2=A04. checkstyle violations are printed out to the console -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org