From hdfs-issues-return-269986-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Mon Jul 1 03:05:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 131B7180645 for ; Mon, 1 Jul 2019 05:05:01 +0200 (CEST) Received: (qmail 85097 invoked by uid 500); 1 Jul 2019 03:05:01 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 85077 invoked by uid 99); 1 Jul 2019 03:05:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Jul 2019 03:05:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7D875E2AFF for ; Mon, 1 Jul 2019 03:05:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3F1B925FFA for ; Mon, 1 Jul 2019 03:05:00 +0000 (UTC) Date: Mon, 1 Jul 2019 03:05:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (HDDS-1730) Implement File CreateDirectory Request to use Cache and DoubleBuffer MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDDS-1730?focusedWorklogId=3D2= 69945&page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpan= el#worklog-269945 ] ASF GitHub Bot logged work on HDDS-1730: ---------------------------------------- Author: ASF GitHub Bot Created on: 01/Jul/19 03:04 Start Date: 01/Jul/19 03:04 Worklog Time Spent: 10m=20 Work Description: bharatviswa504 commented on pull request #1026: HDD= S-1730. Implement File CreateDirectory Request to use Cache and Do=E2=80=A6 URL: https://github.com/apache/hadoop/pull/1026#discussion_r298869209 =20 =20 ########## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozon= e/om/request/file/OMDirectoryCreateRequest.java ########## @@ -0,0 +1,282 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + *

+ * http://www.apache.org/licenses/LICENSE-2.0 + *

+ * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied= . + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.om.request.file; + +import java.io.IOException; +import java.nio.file.Path; +import java.nio.file.Paths; +import java.util.ArrayList; +import java.util.Collections; +import java.util.Map; + +import com.google.common.base.Optional; +import com.google.common.base.Preconditions; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import org.apache.hadoop.fs.FileEncryptionInfo; +import org.apache.hadoop.hdds.protocol.proto.HddsProtos; +import org.apache.hadoop.ozone.audit.AuditLogger; +import org.apache.hadoop.ozone.audit.OMAction; +import org.apache.hadoop.ozone.om.OMMetadataManager; +import org.apache.hadoop.ozone.om.OMMetrics; +import org.apache.hadoop.ozone.om.OzoneManager; +import org.apache.hadoop.ozone.om.exceptions.OMException; +import org.apache.hadoop.ozone.om.helpers.OmBucketInfo; +import org.apache.hadoop.ozone.om.helpers.OmKeyInfo; +import org.apache.hadoop.ozone.om.helpers.OmKeyLocationInfoGroup; +import org.apache.hadoop.ozone.om.helpers.OzoneFSUtils; +import org.apache.hadoop.ozone.om.request.OMClientRequest; +import org.apache.hadoop.ozone.om.request.key.OMKeyRequest; +import org.apache.hadoop.ozone.om.response.OMClientResponse; +import org.apache.hadoop.ozone.om.response.file.OMDirectoryCreateResponse; +import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos; +import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos + .CreateDirectoryRequest; +import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos + .CreateDirectoryResponse; +import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos + .KeyArgs; +import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos + .OMRequest; +import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos + .OMResponse; +import org.apache.hadoop.ozone.security.acl.IAccessAuthorizer; +import org.apache.hadoop.ozone.security.acl.OzoneObj; +import org.apache.hadoop.util.Time; +import org.apache.hadoop.utils.db.cache.CacheKey; +import org.apache.hadoop.utils.db.cache.CacheValue; + + +import static org.apache.hadoop.ozone.om.exceptions.OMException.ResultCode= s.BUCKET_NOT_FOUND; +import static org.apache.hadoop.ozone.om.exceptions.OMException.ResultCode= s.FILE_ALREADY_EXISTS; +import static org.apache.hadoop.ozone.om.lock.OzoneManagerLock.Resource.B= UCKET_LOCK; +/** + * Handle create directory request. + */ +public class OMDirectoryCreateRequest extends OMClientRequest + implements OMKeyRequest { + + private static final Logger LOG =3D + LoggerFactory.getLogger(OMDirectoryCreateRequest.class); + + public OMDirectoryCreateRequest(OMRequest omRequest) { + super(omRequest); + } + + @Override + public OMRequest preExecute(OzoneManager ozoneManager) { + CreateDirectoryRequest createDirectoryRequest =3D + getOmRequest().getCreateDirectoryRequest(); + Preconditions.checkNotNull(createDirectoryRequest); + + KeyArgs.Builder newKeyArgs =3D createDirectoryRequest.getKeyArgs() + .toBuilder().setModificationTime(Time.now()); + + CreateDirectoryRequest.Builder newCreateDirectoryRequest =3D + createDirectoryRequest.toBuilder().setKeyArgs(newKeyArgs); + + return getOmRequest().toBuilder().setCreateDirectoryRequest( + newCreateDirectoryRequest).build(); + + } + + @Override + public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager= , + long transactionLogIndex) { + + KeyArgs keyArgs =3D getOmRequest().getCreateDirectoryRequest().getKeyA= rgs(); + + String volumeName =3D keyArgs.getVolumeName(); + String bucketName =3D keyArgs.getBucketName(); + String keyName =3D keyArgs.getKeyName(); + + OMResponse.Builder omResponse =3D + OzoneManagerProtocolProtos.OMResponse.newBuilder().setCmdType( + OzoneManagerProtocolProtos.Type.CreateDirectory).setStatus( + OzoneManagerProtocolProtos.Status.OK); + + OMMetrics omMetrics =3D ozoneManager.getMetrics(); + omMetrics.incNumCreateDirectory(); + + AuditLogger auditLogger =3D ozoneManager.getAuditLogger(); + OzoneManagerProtocolProtos.UserInfo userInfo =3D getOmRequest().getUse= rInfo(); + + Map auditMap =3D buildKeyArgsAuditMap(keyArgs); + OMMetadataManager omMetadataManager =3D ozoneManager.getMetadataManage= r(); + boolean acquiredLock =3D false; + IOException exception =3D null; + OmKeyInfo dirKeyInfo =3D null; + + try { + // check Acl + if (ozoneManager.getAclsEnabled()) { + checkAcls(ozoneManager, OzoneObj.ResourceType.BUCKET, + OzoneObj.StoreType.OZONE, IAccessAuthorizer.ACLType.WRITE, + volumeName, bucketName, keyName); + } + + // Check if this is the root of the filesystem. + if (keyName.length() =3D=3D 0) { + return new OMDirectoryCreateResponse(null, + omResponse.setCreateDirectoryResponse( + CreateDirectoryResponse.newBuilder()).build()); + } + // acquire lock + acquiredLock =3D omMetadataManager.getLock().acquireLock(BUCKET_LOCK= , + volumeName, bucketName); + + // TODO: Not checking volume exist here, once we have full cache we = can =20 Review comment: This check is to throw a specific error like volume not found. I think this is right now not a blocker, it is similar to what we have d= one in Key requests. https://issues.apache.org/jira/browse/HDDS-1737 =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 269945) Time Spent: 2h 40m (was: 2.5h) > Implement File CreateDirectory Request to use Cache and DoubleBuffer > -------------------------------------------------------------------- > > Key: HDDS-1730 > URL: https://issues.apache.org/jira/browse/HDDS-1730 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Reporter: Bharat Viswanadham > Assignee: Bharat Viswanadham > Priority: Major > Labels: pull-request-available > Time Spent: 2h 40m > Remaining Estimate: 0h > > In this Jira, we shall implement createDirectory request according to the= HA model, and use cache and double buffer. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org