From hdfs-issues-return-272266-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Tue Jul 16 14:25:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id BD86F18064E for ; Tue, 16 Jul 2019 16:25:04 +0200 (CEST) Received: (qmail 98419 invoked by uid 500); 16 Jul 2019 14:25:01 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 98236 invoked by uid 99); 16 Jul 2019 14:25:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jul 2019 14:25:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7A7D5E2ED1 for ; Tue, 16 Jul 2019 14:25:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3536826590 for ; Tue, 16 Jul 2019 14:25:00 +0000 (UTC) Date: Tue, 16 Jul 2019 14:25:00 +0000 (UTC) From: "Ayush Saxena (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-13577) RBF: Failed mount point operations, returns wrong exit code. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-13577?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1688= 6154#comment-16886154 ]=20 Ayush Saxena commented on HDFS-13577: ------------------------------------- This seems fixed :: {code:java} if (!added) { System.err.println("Cannot add mount point " + mount); } return added; {code} The said message shall be printed when added is false, and same false is re= turned. Then :: {code:java} if (addMount(argv, i)) { System.out.println("Successfully added mount point " + argv[i]); } else { exitCode =3D -1; } {code} Here addMount(argv,i) receives response as False, Moves to else, sets exit = code to -1. Verified, Seems not an issue now. Can resolve this now!!! > RBF: Failed mount point operations, returns wrong exit code. > ------------------------------------------------------------ > > Key: HDFS-13577 > URL: https://issues.apache.org/jira/browse/HDFS-13577 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Y. SREENIVASULU REDDY > Assignee: Dibyendu Karmakar > Priority: Major > Labels: RBF > > If client is performed add mount point with some special character, mount= point add is failed. > And prints the message like > {noformat} > 18/05/17 09:58:34 DEBUG ipc.ProtobufRpcEngine: Call: addMountTableEntry t= ook 19ms Cannot add mount point /testSpecialCharMountPointCreation/test/=01 > {noformat} > In the above case it should return the exist code is non zero value. > {code:java|title=3DRouterAdmin.java|borderStyle=3Dsolid} > Exception debugException =3D null; > exitCode =3D 0; > try { > if ("-add".equals(cmd)) { > if (addMount(argv, i)) { > System.out.println("Successfully added mount point " + argv[i]); > } > {code} > we should handle=C2=A0this kind of cases also. -- This message was sent by Atlassian JIRA (v7.6.14#76016) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org