hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Yang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDDS-1833) RefCountedDB printing of stacktrace should be moved to trace logging
Date Thu, 25 Jul 2019 23:22:00 GMT

    [ https://issues.apache.org/jira/browse/HDDS-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16893208#comment-16893208
] 

Eric Yang commented on HDDS-1833:
---------------------------------

[~swagle] Thank you for the patch.  Generating the full stack may take more compute cycles.
 If this is a frequently called API, I would recommend to keep the if statement to perform
stack trace computation only when trace is turned on.  If this is not a frequently called
API, the patch 3 looks good to me.

> RefCountedDB printing of stacktrace should be moved to trace logging
> --------------------------------------------------------------------
>
>                 Key: HDDS-1833
>                 URL: https://issues.apache.org/jira/browse/HDDS-1833
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: Ozone Datanode
>    Affects Versions: 0.4.0
>            Reporter: Mukul Kumar Singh
>            Assignee: Siddharth Wagle
>            Priority: Major
>              Labels: newbie
>         Attachments: HDDS-1833.01.patch, HDDS-1833.02.patch, HDDS-1833.03.patch
>
>
> RefCountedDB logs the stackTrace for both increment and decrement, this pollutes the
logs.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message