hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doroszlai, Attila (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDDS-1800) Result of author check is inverted
Date Mon, 15 Jul 2019 15:59:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Doroszlai, Attila updated HDDS-1800:
------------------------------------
    Status: Patch Available  (was: Open)

> Result of author check is inverted
> ----------------------------------
>
>                 Key: HDDS-1800
>                 URL: https://issues.apache.org/jira/browse/HDDS-1800
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>            Reporter: Doroszlai, Attila
>            Assignee: Doroszlai, Attila
>            Priority: Major
>
> h2. What changes were proposed in this pull request?
> h2. 
> Fix:
>  1. author check fails when no violations are found
>  2. author check violations are duplicated in the output
> Eg. https://ci.anzix.net/job/ozone-nightly/173/consoleText says that:
> {code:java}
> The following tests are FAILED:
> [author]: author check is failed (https://ci.anzix.net/job/ozone-nightly/173//artifact/build/author.out/*view*/){code}
> but no actual `@author` tags were found:
> {code}
> $ curl -s 'https://ci.anzix.net/job/ozone-nightly/173//artifact/build/author.out/*view*/'
| wc
>        0       0       0
> {code}
> h2. How was this patch tested?
> {code}
> $ bash -o pipefail -c 'hadoop-ozone/dev-support/checks/author.sh | tee build/author.out';
echo $?
> 0
> $ wc build/author.out
>        0       0       0 build/author.out
> $ echo '// @author Tolkien' >> hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManager.java
> $ bash -o pipefail -c 'hadoop-ozone/dev-support/checks/author.sh | tee build/author.out';
echo $?
> ./hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManager.java://
@author Tolkien
> 1
> $ wc build/author.out
>        1       3     108 build/author.out
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message