hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-1779) TestWatchForCommit tests are flaky
Date Fri, 12 Jul 2019 05:00:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-1779?focusedWorklogId=275643&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-275643
]

ASF GitHub Bot logged work on HDDS-1779:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Jul/19 04:59
            Start Date: 12/Jul/19 04:59
    Worklog Time Spent: 10m 
      Work Description: supratimdeka commented on pull request #1071: HDDS-1779. TestWatchForCommit
tests are flaky.
URL: https://github.com/apache/hadoop/pull/1071#discussion_r302827060
 
 

 ##########
 File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestWatchForCommit.java
 ##########
 @@ -343,61 +349,24 @@ public void testWatchForCommitForRetryfailure() throws Exception {
     cluster.shutdownHddsDatanode(pipeline.getNodes().get(1));
     // again write data with more than max buffer limit. This wi
     try {
-      // just watch for a lo index which in not updated in the commitInfo Map
-      xceiverClient.watchForCommit(index + 1, 20000);
+      // just watch for a log index which in not updated in the commitInfo Map
+      // as well as there is no logIndex generate in Ratis.
+      // The basic idea here is just to test if its throws an exception.
+      xceiverClient
+          .watchForCommit(index + new Random().nextInt(100) + 10, 20000);
 
 Review comment:
   instead of a Random increment, why not increment by a fixed number everytime - say 100
or 110? This applies to all the other modified test cases as well.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 275643)
    Time Spent: 40m  (was: 0.5h)

> TestWatchForCommit tests are flaky
> ----------------------------------
>
>                 Key: HDDS-1779
>                 URL: https://issues.apache.org/jira/browse/HDDS-1779
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>            Reporter: Shashikant Banerjee
>            Assignee: Shashikant Banerjee
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> The tests have become flaky bcoz onceĀ  nodes are shutdown inn Ratis pipeline, a watch
request can either be received at server at a server and fail with NotReplicatedException
or sometimes it fails with StatusRuntimeExceptions from grpc which both need to be accounted
for in the tests. Other than that, HDDS-1384 also causes bind exception to e thrown intermittently
which in turn shuts down the miniOzoneCluster. To overcome this, the test class has been refactored
as well.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message