hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-1775) Make OM KeyDeletingService compatible with HA model
Date Tue, 09 Jul 2019 20:40:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-1775?focusedWorklogId=274377&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-274377

ASF GitHub Bot logged work on HDDS-1775:

                Author: ASF GitHub Bot
            Created on: 09/Jul/19 20:39
            Start Date: 09/Jul/19 20:39
    Worklog Time Spent: 10m 
      Work Description: arp7 commented on pull request #1063: HDDS-1775. Make OM KeyDeletingService
compatible with HA model
URL: https://github.com/apache/hadoop/pull/1063#discussion_r301778230

 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyDeletingService.java
 @@ -55,17 +58,21 @@
   // The thread pool size for key deleting service.
   private final static int KEY_DELETING_CORE_POOL_SIZE = 2;
+  private final OzoneManager ozoneManager;
   private final ScmBlockLocationProtocol scmClient;
   private final KeyManager manager;
+  private ClientId clientId = ClientId.randomId();
   private final int keyLimitPerTask;
   private final AtomicLong deletedKeyCount;
   private final AtomicLong runCount;
-  public KeyDeletingService(ScmBlockLocationProtocol scmClient,
+  public KeyDeletingService(OzoneManager ozoneManager,
+      ScmBlockLocationProtocol scmClient,
       KeyManager manager, long serviceInterval,
       long serviceTimeout, Configuration conf) {
     super("KeyDeletingService", serviceInterval, TimeUnit.MILLISECONDS,
         KEY_DELETING_CORE_POOL_SIZE, serviceTimeout);
+    this.ozoneManager = ozoneManager;
 Review comment:
   Can you think of a way to avoid passing `OzoneManager` to this class? We now have a low
level class depending on a higher level class and potentially a circular dependency.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 274377)
    Time Spent: 50m  (was: 40m)

> Make OM KeyDeletingService compatible with HA model
> ---------------------------------------------------
>                 Key: HDDS-1775
>                 URL: https://issues.apache.org/jira/browse/HDDS-1775
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Hanisha Koneru
>            Assignee: Hanisha Koneru
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
> Currently OM KeyDeletingService directly deletes all the keys in DeletedTable after deleting
the corresponding blocks through SCM. For HA compatibility, the key purging should happen
through the OM Ratis server. This Jira introduces PurgeKeys request in OM protocol. This request
will be submitted to OMs Ratis server after SCM deletes blocks corresponding to deleted keys.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message