hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharat Viswanadham (JIRA)" <j...@apache.org>
Subject [jira] [Assigned] (HDDS-1761) Fix class hierarchy for OMKeyCreateRequest and OMFileCreateRequest
Date Wed, 03 Jul 2019 19:00:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Bharat Viswanadham reassigned HDDS-1761:
----------------------------------------

    Assignee: Bharat Viswanadham

> Fix class hierarchy for OMKeyCreateRequest and OMFileCreateRequest
> ------------------------------------------------------------------
>
>                 Key: HDDS-1761
>                 URL: https://issues.apache.org/jira/browse/HDDS-1761
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Major
>
> The patch looks mostly fine to me. A few minor comments. -and one type error that needs
to be fixed.-
> I would like to see the class hierarchy refactored in a follow up patch. {{OMFileCreateRequest}}should
not extend {{OMKeyCreateRequest}}. Instead they should both extend an abstract class that
encapsulates the common functionality.
> Generally deriving from _concrete_ classes is a bad idea.
>  
> This Jira is created based on [~arp] comment during review of HDDS-1731



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message