hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-1748) Error message for 3 way commit failure is not verbose
Date Mon, 08 Jul 2019 08:57:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-1748?focusedWorklogId=273165&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-273165
]

ASF GitHub Bot logged work on HDDS-1748:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Jul/19 08:56
            Start Date: 08/Jul/19 08:56
    Worklog Time Spent: 10m 
      Work Description: mukul1987 commented on pull request #1051: HDDS-1748. Error message
for 3 way commit failure is not verbose. Contributed by Supratim Deka
URL: https://github.com/apache/hadoop/pull/1051#discussion_r300987398
 
 

 ##########
 File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockOutputStream.java
 ##########
 @@ -356,9 +356,16 @@ private void watchForCommit(boolean bufferFull) throws IOException {
       if (reply != null) {
         List<DatanodeDetails> dnList = reply.getDatanodes();
         if (!dnList.isEmpty()) {
-          if (failedServers.isEmpty()) {
-            failedServers = new ArrayList<>();
-          }
+          Pipeline pipe = xceiverClient.getPipeline();
+
+          StringBuilder err = new StringBuilder();
+          err.append("Failed to commit BlockId ").append(blockID);
+          err.append(" on Pipeline ").append(pipe);
+
+          err.append(" failed nodes: ");
 
 Review comment:
   same here.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 273165)
    Time Spent: 1h  (was: 50m)

> Error message for 3 way commit failure is not verbose
> -----------------------------------------------------
>
>                 Key: HDDS-1748
>                 URL: https://issues.apache.org/jira/browse/HDDS-1748
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: Ozone Client
>    Affects Versions: 0.4.0
>            Reporter: Mukul Kumar Singh
>            Assignee: Supratim Deka
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> The error message for 3 way client commit is not verbose, it should include blockID and
pipeline ID along with node details for debugging.
> {code}
> 2019-07-02 09:58:12,025 WARN  scm.XceiverClientRatis (XceiverClientRatis.java:watchForCommit(262))
- 3 way commit failed 
> java.util.concurrent.ExecutionException: org.apache.ratis.protocol.NotReplicatedException:
Request with call Id 39482 and log index 11562 is not yet replicated to ALL_COMMITTED
>         at java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357)
>         at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1915)
>         at org.apache.hadoop.hdds.scm.XceiverClientRatis.watchForCommit(XceiverClientRatis.java:259)
>         at org.apache.hadoop.hdds.scm.storage.CommitWatcher.watchForCommit(CommitWatcher.java:194)
>         at org.apache.hadoop.hdds.scm.storage.CommitWatcher.watchOnFirstIndex(CommitWatcher.java:135)
>         at org.apache.hadoop.hdds.scm.storage.BlockOutputStream.watchForCommit(BlockOutputStream.java:355)
>         at org.apache.hadoop.hdds.scm.storage.BlockOutputStream.handleFullBuffer(BlockOutputStream.java:332)
>         at org.apache.hadoop.hdds.scm.storage.BlockOutputStream.write(BlockOutputStream.java:259)
>         at org.apache.hadoop.ozone.client.io.BlockOutputStreamEntry.write(BlockOutputStreamEntry.java:129)
>         at org.apache.hadoop.ozone.client.io.KeyOutputStream.handleWrite(KeyOutputStream.java:211)
>         at org.apache.hadoop.ozone.client.io.KeyOutputStream.write(KeyOutputStream.java:193)
>         at org.apache.hadoop.ozone.client.io.OzoneOutputStream.write(OzoneOutputStream.java:49)
>         at java.io.OutputStream.write(OutputStream.java:75)
>         at org.apache.hadoop.ozone.MiniOzoneLoadGenerator.load(MiniOzoneLoadGenerator.java:103)
>         at org.apache.hadoop.ozone.MiniOzoneLoadGenerator.lambda$startIO$0(MiniOzoneLoadGenerator.java:147)
>         at java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1626)
>         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>         at java.lang.Thread.run(Thread.java:748)
> Caused by: org.apache.ratis.protocol.NotReplicatedException: Request with call Id 39482
and log index 11562 is not yet replicated to ALL_COMMITTED
>         at org.apache.ratis.client.impl.ClientProtoUtils.toRaftClientReply(ClientProtoUtils.java:245)
>         at org.apache.ratis.grpc.client.GrpcClientProtocolClient$AsyncStreamObservers$1.onNext(GrpcClientProtocolClient.java:254)
>         at org.apache.ratis.grpc.client.GrpcClientProtocolClient$AsyncStreamObservers$1.onNext(GrpcClientProtocolClient.java:249)
>         at org.apache.ratis.thirdparty.io.grpc.stub.ClientCalls$StreamObserverToCallListenerAdapter.onMessage(ClientCalls.java:421)
>         at org.apache.ratis.thirdparty.io.grpc.ForwardingClientCallListener.onMessage(ForwardingClientCallListener.java:33)
>         at org.apache.ratis.thirdparty.io.grpc.ForwardingClientCallListener.onMessage(ForwardingClientCallListener.java:33)
>         at org.apache.ratis.thirdparty.io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl$1MessagesAvailable.runInContext(ClientCallImpl.java:519)
>         at org.apache.ratis.thirdparty.io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
>         at org.apache.ratis.thirdparty.io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:123)
>         ... 3 more
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message