hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anu Engineer (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDDS-1735) Create separate unit and integration test executor dev-support script
Date Tue, 02 Jul 2019 05:31:00 GMT

    [ https://issues.apache.org/jira/browse/HDDS-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876671#comment-16876671
] 

Anu Engineer edited comment on HDDS-1735 at 7/2/19 5:30 AM:
------------------------------------------------------------

{quote}Look for the section, Testing your patch
{quote}
It tells how to run Hadoop on my Mac. My question was:
{quote}Can you point me to an instruction – or documentation that explain how to even setup
Yetus on my Mac
{quote}
Completely different question.

 
{quote}Checkstyle, findbugs, rat plugins, shellcheck, Dockerfile checks are all using default
or relaxed rules sets
{quote}
You are making assertions without data to back you up. I will personally assert what you saying
is completely wrong. To the point that I think you have no idea what you are talking about.
 # Let us do some tests – Take checkstyle – run it over Hadoop HDFS and Hadoop Common
code base and post the result here.
 # Now run the same over Ozone and HDDS directory; post the result here.

I am sure you will not; since It will just expose your false claim.

 

Now let us go to findbugs, Do the same – run the findbugs – Then be a good citizen in
the Hadoop world and fix the issues. I will throw my name in the gauntlet, if you can fix
10% of find bugs issues in HDFS/Hadoop Common code base. I will personally fix all find bugs
issues in Ozone / HDDS code base.

 

Please do not make assertions without knowing what you are talking about.

 

Before we argue your *opinion* vs my *opinion*; let us measure, I really dare you to follow
up on this; if you cannot please hold you peace forever and stop trolling us.

 

 

 

 


was (Author: anu):
{quote}Look for the section, Testing your patch
{quote}
It tells how to run Hadoop on my Mac. My question was:
{quote}Can you point me to an instruction – or documentation that explain how to even setup
Yetus on my Mac
{quote}
Completely different question.

 
{quote}Checkstyle, findbugs, rat plugins, shellcheck, Dockerfile checks are all using default
or relaxed rules sets
{quote}
You are making assertions without data to back you up. I will personally assert what you saying
is completely wrong. To the point that I think you have no idea what you are talking about.
 # Let us do some tests – Take checkstyle – run it over Hadoop HDFS and Hadoop Common
code base and post the result here.
 # Now run the same over Ozone and HDDS directory; post the result here.

I am sure you will not; since It will just expose your false claim.

 

Now let us go to findbugs, Do the same – run the findbugs – Then be a good citizen in
the Hadoop world and fix the issues. I will throw my name in the gaunlet, if you can fix 10%
of find bugs issues in HDFS/Hadoop Common code base. I will personally fix all find bugs issues
in Ozone / HDDS code base.

 

Please do not make assertions without knowing what you are talking about.

 

Before we argue your *opinion* vs my *opinion*; let us measure, I really dare you to follow
up on this; if you cannot please hold you peace forever and stop trolling us.

 

 

 

 

> Create separate unit and integration test executor dev-support script
> ---------------------------------------------------------------------
>
>                 Key: HDDS-1735
>                 URL: https://issues.apache.org/jira/browse/HDDS-1735
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> hadoop-ozone/dev-support/checks directory contains multiple helper script to execute
different type of testing (findbugs, rat, unit, build).
> They easily define how tests should be executed, with the following contract:
>  * The problems should be printed out to the console
>  * in case of test failure a non zero exit code should be used
>  
> The tests are working well (in fact I have some experiments with executing these scripts
on k8s and argo where all the shell scripts are executed parallel) but we need some update:
>  1. Most important: the unit tests and integration tests can be separated. Integration
tests are more flaky and it's better to have a way to run only the normal unit tests
>  2. As HDDS-1115 introduced a pom.ozone.xml it's better to use them instead of the magical
"am pl hadoop-ozone-dist" trick--
>  3. To make it possible to run blockade test in containers we should use - T flag with
docker-compose
>  4. checkstyle violations are printed out to the console



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message