hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ayush Saxena (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-14595) HDFS-11848 breaks API compatibility
Date Mon, 22 Jul 2019 08:06:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889987#comment-16889987
] 

Ayush Saxena commented on HDFS-14595:
-------------------------------------

I guess to avoid the incompatibility, we just need to ensure any public API isn't removed..
That what got removed here in DIstributedFileSytem and HDFSAdmin, To counter that we just
need to add overloaded methods having only one parameter, and that can call the existing one
with default Value(OpenFilesIterator.FILTER_PATH_DEFAULT) and we can use the same invocation
track, without having any changes in the protocol and namenode side. The API in the {{NamenodeRPCServer}}
will not even be invoked only, because, 
from ClientNameNodeProtocolTranslator itself, we are using existing API with OpenFilesIterator.FILTER_PATH_DEFAULT
as path and for a new API to be invoked you need to add the method in ClientNameNodeProtocol.proto.

 

> HDFS-11848 breaks API compatibility
> -----------------------------------
>
>                 Key: HDFS-14595
>                 URL: https://issues.apache.org/jira/browse/HDFS-14595
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.2.0, 3.1.2
>            Reporter: Wei-Chiu Chuang
>            Assignee: Siyao Meng
>            Priority: Blocker
>         Attachments: HDFS-14595.001.patch, HDFS-14595.002.patch, hadoop_ 36e1870eab904d5a6f12ecfb1fdb52ca08d95ac5
to b241194d56f97ee372cbec7062bcf155bc3df662 compatibility report.htm
>
>
> Our internal tool caught an API compatibility issue with HDFS-11848.
> HDFS-11848 adds an additional parameter to DistributedFileSystem.listOpenFiles(), but
it doesn't keep the existing API.
> This can cause issue when upgrading from Hadoop 2.9.0/2.8.3/3.0.0 to 3.0.1/3.1.0 and
above.
> Suggest:
> (1) Add back the old API (which was added in HDFS-10480), and mark it deprecated.
> (2) Update release doc to enforce running API compatibility check for each releases.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message