hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDDS-1258) Fix error propagation for SCM protocol
Date Mon, 01 Jul 2019 18:21:00 GMT

    [ https://issues.apache.org/jira/browse/HDDS-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876407#comment-16876407
] 

Hudson commented on HDDS-1258:
------------------------------

FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #16845 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/16845/])
HDDS-1258. Fix error propagation for SCM protocol (elek: rev f8d62a9c4c03a637896bf4f1795176901c4e7235)
* (edit) hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/protocolPB/ScmBlockLocationProtocolServerSideTranslatorPB.java
* (edit) hadoop-hdds/common/src/main/proto/ScmBlockLocationProtocol.proto
* (edit) hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/exceptions/SCMException.java
* (add) hadoop-hdds/common/src/test/java/org/apache/hadoop/hdds/scm/exceptions/TestSCMExceptionResultCodes.java
* (edit) hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/protocolPB/ScmBlockLocationProtocolClientSideTranslatorPB.java
* (edit) hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/exceptions/package-info.java


> Fix error propagation for SCM protocol
> --------------------------------------
>
>                 Key: HDDS-1258
>                 URL: https://issues.apache.org/jira/browse/HDDS-1258
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>            Reporter: Elek, Marton
>            Assignee: Stephen O'Donnell
>            Priority: Critical
>              Labels: pull-request-available
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> HDDS-1068 fixed the error propagation between the OM client and OM server.
> By default the Server.java transforms all the IOExceptions to one string (message + stack
trace) and this is returned to the client.
> But for business exception (eg. volume not found, chill mode is active, etc.) this is
not what we need.
> In the OM side we fixed this behaviour. In the ServerSideTranslator classes we catch
(server) the business (OMException) exceptions and serialize them to the response object.
> The exception (and the status code) is stored in message/status field of the OMResponse
(hadoop-ozone/common/src/main/proto/OzoneManagerProtocol.proto)
> Here I propose to do the same for the ScmBlockLocationProtocol.proto.
> Unfortunately there is no common parent object (like OMRequest) in this protocol, but
we can easily add one as only the Serverside/Clientside translator should be changed for that.




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message