From hdfs-issues-return-269443-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Tue Jun 25 21:20:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 719FF18067C for ; Tue, 25 Jun 2019 23:20:03 +0200 (CEST) Received: (qmail 26802 invoked by uid 500); 25 Jun 2019 21:20:02 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 26497 invoked by uid 99); 25 Jun 2019 21:20:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Jun 2019 21:20:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0EFFAE2E2B for ; Tue, 25 Jun 2019 21:20:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 786D92581B for ; Tue, 25 Jun 2019 21:20:00 +0000 (UTC) Date: Tue, 25 Jun 2019 21:20:00 +0000 (UTC) From: "Hadoop QA (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-14608) DataNode$DataTransfer should be named MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-14608?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1687= 2728#comment-16872728 ]=20 Hadoop QA commented on HDFS-14608: ---------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 11s= {color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0= m 0s{color} | {color:green} The patch does not contain any @author tags. {= color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m = 0s{color} | {color:red} The patch doesn't appear to include any new or modi= fied tests. Please justify why no new tests are needed for this patch. Also= please list what manual steps were performed to verify this patch. {color}= | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 19m 27s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1= m 0s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 0m 45s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1= m 7s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:gree= n} 13m 20s{color} | {color:green} branch has no errors when building and te= sting our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} = 2m 7s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0= m 50s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 0m 59s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0= m 55s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m = 55s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 0m 38s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1= m 2s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green}= 0m 0s{color} | {color:green} The patch has no whitespace issues. {color}= | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:gree= n} 12m 30s{color} | {color:green} patch has no errors when building and tes= ting our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} = 2m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0= m 47s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 90m 0s{col= or} | {color:red} hadoop-hdfs in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green}= 0m 36s{color} | {color:green} The patch does not generate ASF License war= nings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}148m 22s{colo= r} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hdfs.server.datanode.TestDirectoryScanner | | | hadoop.hdfs.TestMultipleNNPortQOP | | | hadoop.hdfs.server.diskbalancer.TestDiskBalancer | | | hadoop.hdfs.web.TestWebHdfsTimeouts | | | hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks | | | hadoop.hdfs.TestSafeMode | | | hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA | | | hadoop.hdfs.TestSafeModeWithStripedFile | \\ \\ || Subsystem || Report/Notes || | Docker | Client=3D17.05.0-ce Server=3D17.05.0-ce Image:yetus/hadoop:bdbca= 0e | | JIRA Issue | HDFS-14608 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/1297290= 0/HDFS-14608.000.patch | | Optional Tests | dupname asflicense compile javac javadoc mvninstal= l mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 805ee4418fdb 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed = Feb 13 15:00:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 049bb42 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_212 | | findbugs | v3.1.0-RC1 | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/27084/artifact/= out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/27084/= testReport/ | | Max. process+thread count | 3391 (vs. ulimit of 10000) | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoo= p-hdfs | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/27084= /console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > DataNode$DataTransfer should be named > ------------------------------------- > > Key: HDFS-14608 > URL: https://issues.apache.org/jira/browse/HDFS-14608 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: =C3=8D=C3=B1igo Goiri > Assignee: =C3=8D=C3=B1igo Goiri > Priority: Minor > Fix For: 3.3.0 > > Attachments: HDFS-14608.000.patch > > > Currently, the {{DataTransfer}} thread has no name and it just outputs th= e default {{toString()}}. > This shows in the logs in jstack as something like: > {code} > 2019-06-25 11:01:01,211 INFO [org.apache.hadoop.hdfs.server.datanode.Data= Node$DataTransfer@609ed67a] org.apache.hadoop.hdfs.server.datanode.DataNode= : DataTransfer, at CO4AEAP0000C1AF:10010: Transmitted BP-1191059133-10.1.2.= 3-1458888702348:blk_1113379522_69745835 (numBytes=3D485214) to 10.1.2.3/10.= 1.2.3:10010 > {code} > As this uses the {{Daemon}} class, the name is set based on: > {code} > public Daemon(Runnable runnable) { > super(runnable); > this.runnable =3D runnable; > this.setName(((Object)runnable).toString()); > } > {code} > We should implement toString to at least have the name of the block being= transfferred or something similar to what DataXceiver does (e.g., HDFS-337= 5). -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org