From hdfs-issues-return-266905-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Mon Jun 10 16:41:06 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id A88F2180649 for ; Mon, 10 Jun 2019 18:41:05 +0200 (CEST) Received: (qmail 150 invoked by uid 500); 10 Jun 2019 16:41:01 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 128 invoked by uid 99); 10 Jun 2019 16:41:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Jun 2019 16:41:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8F5BDE2CC5 for ; Mon, 10 Jun 2019 16:41:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4183D24633 for ; Mon, 10 Jun 2019 16:41:00 +0000 (UTC) Date: Mon, 10 Jun 2019 16:41:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (HDDS-1545) Cli to add,remove,get and delete acls for Ozone objects MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDDS-1545?focusedWorklogId=256956&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-256956 ] ASF GitHub Bot logged work on HDDS-1545: ---------------------------------------- Author: ASF GitHub Bot Created on: 10/Jun/19 16:40 Start Date: 10/Jun/19 16:40 Worklog Time Spent: 10m Work Description: ajayydv commented on pull request #920: HDDS-1545. Cli to add,remove,get and delete acls for Ozone objects. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/920#discussion_r292090328 ########## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/keys/SetAclKeyHandler.java ########## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.ozone.web.ozShell.keys; + +import org.apache.hadoop.ozone.OzoneAcl; +import org.apache.hadoop.ozone.client.OzoneClient; +import org.apache.hadoop.ozone.security.acl.OzoneObj; +import org.apache.hadoop.ozone.security.acl.OzoneObjInfo; +import org.apache.hadoop.ozone.web.ozShell.Handler; +import org.apache.hadoop.ozone.web.ozShell.OzoneAddress; +import org.apache.hadoop.ozone.web.ozShell.Shell; +import org.apache.hadoop.ozone.web.utils.JsonUtils; +import picocli.CommandLine; +import picocli.CommandLine.Command; +import picocli.CommandLine.Parameters; + +import java.util.Objects; + +import static org.apache.hadoop.ozone.security.acl.OzoneObj.StoreType.OZONE; + +/** + * Executes Info bucket. + */ +@Command(name = "setacl", + description = "Set acls.") +public class SetAclKeyHandler extends Handler { + + @Parameters(arity = "1..1", description = Shell.OZONE_BUCKET_URI_DESCRIPTION) + private String uri; + + @CommandLine.Option(names = {"--acls", "-al"}, + required = true, + description = "Comma seperated acls." + + "r = READ," + + "w = WRITE," + + "c = CREATE," + + "d = DELETE," + + "l = LIST," + + "a = ALL," + + "n = NONE," + + "x = READ_AC," + + "y = WRITE_AC" + + "Ex user:user1:rw,user:user2:a,group:hadoop:a") + private String acls; + + @CommandLine.Option(names = {"--store", "-s"}, + required = false, + description = "store type. i.e OZONE or S3") + private String storeType; + + /** + * Executes the Client Calls. + */ + @Override + public Void call() throws Exception { + Objects.requireNonNull(acls, "New acls to be added not specified."); + OzoneAddress address = new OzoneAddress(uri); + address.ensureKeyAddress(); + OzoneClient client = address.createClient(createOzoneConfiguration()); Review comment: done ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 256956) Time Spent: 4h (was: 3h 50m) > Cli to add,remove,get and delete acls for Ozone objects > ------------------------------------------------------- > > Key: HDDS-1545 > URL: https://issues.apache.org/jira/browse/HDDS-1545 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Reporter: Ajay Kumar > Assignee: Ajay Kumar > Priority: Major > Labels: pull-request-available > Time Spent: 4h > Remaining Estimate: 0h > > Update Ozone Cli to add,remove,get and delete acls for Ozone objects -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org