From hdfs-issues-return-269569-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Thu Jun 27 04:16:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E3AC618064D for ; Thu, 27 Jun 2019 06:16:02 +0200 (CEST) Received: (qmail 46631 invoked by uid 500); 27 Jun 2019 04:16:01 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 46563 invoked by uid 99); 27 Jun 2019 04:16:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Jun 2019 04:16:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C1B48E2E20 for ; Thu, 27 Jun 2019 04:16:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 8735A25815 for ; Thu, 27 Jun 2019 04:16:00 +0000 (UTC) Date: Thu, 27 Jun 2019 04:16:00 +0000 (UTC) From: "He Xiaoqiao (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-11246) FSNameSystem#logAuditEvent should be called outside the read or write locks MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-11246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] He Xiaoqiao updated HDFS-11246: ------------------------------- Attachment: HDFS-11246.007.patch > FSNameSystem#logAuditEvent should be called outside the read or write locks > --------------------------------------------------------------------------- > > Key: HDFS-11246 > URL: https://issues.apache.org/jira/browse/HDFS-11246 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 2.7.3 > Reporter: Kuhu Shukla > Assignee: Kuhu Shukla > Priority: Major > Attachments: HDFS-11246.001.patch, HDFS-11246.002.patch, HDFS-11246.003.patch, HDFS-11246.004.patch, HDFS-11246.005.patch, HDFS-11246.006.patch, HDFS-11246.007.patch > > > {code} > readLock(); > boolean success = true; > ContentSummary cs; > try { > checkOperation(OperationCategory.READ); > cs = FSDirStatAndListingOp.getContentSummary(dir, src); > } catch (AccessControlException ace) { > success = false; > logAuditEvent(success, operationName, src); > throw ace; > } finally { > readUnlock(operationName); > } > {code} > It would be nice to have audit logging outside the lock esp. in scenarios where applications hammer a given operation several times. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org