hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ayush Saxena (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-14593) RBF: RouterAdmin should be able to remove expired routers from Routers Information
Date Fri, 28 Jun 2019 15:18:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16874987#comment-16874987
] 

Ayush Saxena commented on HDFS-14593:
-------------------------------------

Thanx [~tasanuma] for the patch.

Had a quick look,
 * Shouldn't by default this behavior be disabled rather than being 7 days(To keep it same
for the previous ver)
 * Do you need to catch NPE here:
{code:java}
+          getDriver().remove(record);
+        } catch (NullPointerException e) {
+          LOG.warn("{}: {} doesn't exist in State Store", recordName, record);
+        }
{code}
{{getDriver().remove(record)}} this returns boolean, false if the record isn't there?


> RBF: RouterAdmin should be able to remove expired routers from Routers Information
> ----------------------------------------------------------------------------------
>
>                 Key: HDFS-14593
>                 URL: https://issues.apache.org/jira/browse/HDFS-14593
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: rbf
>            Reporter: Takanobu Asanuma
>            Assignee: Takanobu Asanuma
>            Priority: Major
>         Attachments: HDFS-14593.001.patch, HDFS-14593.002.patch
>
>
> Currently, any router seems to exist in the Router Information eternally.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message