hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Elek, Marton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDDS-1667) Docker compose file may referring to incorrect docker image name
Date Thu, 13 Jun 2019 09:00:00 GMT

    [ https://issues.apache.org/jira/browse/HDDS-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16862846#comment-16862846
] 

Elek, Marton commented on HDDS-1667:
------------------------------------

bq. K8s template spelling errors are independent of this issue.

Agree. Opened HDDS-1678

But in patch v3 you keep the apache/ozone for the dist project but use ${user}/ozone for all
the other. I think it's very-very confusing. I thought that the main reason to use ozone.docker.image
is to get the _same_ value everywhere (even if it's a default).

If you would like to change the default value (which is unrelated to the problem description
of this issue), I have no problems. But please:

 * Use the same default everywhere
 * make sure that during the dist build an 'apache/ozone' value is used everywhere/by default
(for example: set the original value in a dist profile of hadoop-ozone/pom.xml)

> Docker compose file may referring to incorrect docker image name
> ----------------------------------------------------------------
>
>                 Key: HDDS-1667
>                 URL: https://issues.apache.org/jira/browse/HDDS-1667
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>            Priority: Trivial
>             Fix For: 0.4.1
>
>         Attachments: HDDS-1667.001.patch, HDDS-1667.002.patch, HDDS-1667.003.patch
>
>
> In fault injection test, the docker compose file is templated using:
> ${user.name}/ozone:${project.version}
> If user pass in parameter -Ddocker.image to cause docker build to generate a different
name.  This can cause fault injection test to fail/stuck because it could not find the required
docker image.  The fix is simply use docker.image token to filter docker compose file.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message