hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-1617) Restructure the code layout for Ozone Manager
Date Sat, 01 Jun 2019 00:13:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-1617?focusedWorklogId=252136&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-252136
]

ASF GitHub Bot logged work on HDDS-1617:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Jun/19 00:12
            Start Date: 01/Jun/19 00:12
    Worklog Time Spent: 10m 
      Work Description: bharatviswa504 commented on pull request #880: HDDS-1617. Restructure
the code layout for Ozone Manager
URL: https://github.com/apache/hadoop/pull/880#discussion_r289582321
 
 

 ##########
 File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmBucketInfo.java
 ##########
 @@ -98,6 +108,40 @@ private OmBucketInfo(String volumeName,
     this.creationTime = creationTime;
     this.metadata = metadata;
     this.bekInfo = bekInfo;
+    this.bucketFlags = bucketFlags;
+  }
+
+  /**
+   * Returns new builder class that builds a OmBucketInfo.
+   *
+   * @return Builder
+   */
+  public static Builder newBuilder() {
+    return new Builder();
+  }
+
+  /**
+   * Parses BucketInfo protobuf and creates OmBucketInfo.
+   * @param bucketInfo
+   * @return instance of OmBucketInfo
+   */
+  public static OmBucketInfo getFromProtobuf(BucketInfo bucketInfo) {
+    OmBucketInfo.Builder obib = OmBucketInfo.newBuilder()
+        .setVolumeName(bucketInfo.getVolumeName())
+        .setBucketName(bucketInfo.getBucketName())
+        .setAcls(bucketInfo.getAclsList().stream().map(
+            OMPBHelper::convertOzoneAcl).collect(Collectors.toList()))
+        .setIsVersionEnabled(bucketInfo.getIsVersionEnabled())
+        .setStorageType(StorageType.valueOf(bucketInfo.getStorageType()))
 
 Review comment:
   Checking bucketFlags in bucketInfo and adding to OmBucketInfo is not done here.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 252136)
    Time Spent: 1h 20m  (was: 1h 10m)

> Restructure the code layout for Ozone Manager
> ---------------------------------------------
>
>                 Key: HDDS-1617
>                 URL: https://issues.apache.org/jira/browse/HDDS-1617
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>          Components: Ozone Manager
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> The Ozone Manager has a flat structure that deals with lot of specific functions. This
Jira proposes to refactor ozone managers code base and move function specific packages.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message