hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-1600) Add userName and IPAddress as part of OMRequest.
Date Mon, 03 Jun 2019 23:05:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-1600?focusedWorklogId=253452&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-253452
]

ASF GitHub Bot logged work on HDDS-1600:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Jun/19 23:04
            Start Date: 03/Jun/19 23:04
    Worklog Time Spent: 10m 
      Work Description: bharatviswa504 commented on pull request #857: HDDS-1600. Add userName
and IPAddress as part of OMRequest.
URL: https://github.com/apache/hadoop/pull/857#discussion_r290071284
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketSetPropertyRequest.java
 ##########
 @@ -87,15 +87,23 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
     String volumeName = bucketArgs.getVolumeName();
     String bucketName = bucketArgs.getBucketName();
 
-    // acquire lock
-    omMetadataManager.getLock().acquireBucketLock(volumeName, bucketName);
 
     OMResponse.Builder omResponse = OMResponse.newBuilder().setCmdType(
         OzoneManagerProtocolProtos.Type.CreateBucket).setStatus(
         OzoneManagerProtocolProtos.Status.OK);
     OmBucketInfo omBucketInfo = null;
 
     try {
+      // check Acl
+      if (ozoneManager.getAclsEnabled()) {
+        checkAcls(ozoneManager, OzoneObj.ResourceType.BUCKET,
+            OzoneObj.StoreType.OZONE, IAccessAuthorizer.ACLType.WRITE,
+            volumeName, bucketName, null);
+      }
+
+      // acquire lock
+      omMetadataManager.getLock().acquireBucketLock(volumeName, bucketName);
 
 Review comment:
   Fixed.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 253452)
    Time Spent: 4h 10m  (was: 4h)

> Add userName and IPAddress as part of OMRequest.
> ------------------------------------------------
>
>                 Key: HDDS-1600
>                 URL: https://issues.apache.org/jira/browse/HDDS-1600
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 4h 10m
>  Remaining Estimate: 0h
>
> In OM HA, the actual execution of request happens under GRPC context, so UGI object which
we retrieve from ProtobufRpcEngine.Server.getRemoteUser(); will not be available.
> In similar manner ProtobufRpcEngine.Server.getRemoteIp().
>  
> So, during preExecute(which happens under RPC context) extract userName and IPAddress
and add it to the OMRequest, and then send the request to ratis server.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message