hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-1545) Cli to add,remove,get and delete acls for Ozone objects
Date Mon, 10 Jun 2019 00:32:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-1545?focusedWorklogId=256569&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-256569
]

ASF GitHub Bot logged work on HDDS-1545:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Jun/19 00:31
            Start Date: 10/Jun/19 00:31
    Worklog Time Spent: 10m 
      Work Description: ajayydv commented on pull request #920: HDDS-1545. Cli to add,remove,get
and delete acls for Ozone objects. Contributed by Ajay Kumar.
URL: https://github.com/apache/hadoop/pull/920#discussion_r291856482
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/bucket/RemoveAclBucketHandler.java
 ##########
 @@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ *  with the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+package org.apache.hadoop.ozone.web.ozShell.bucket;
+
+import org.apache.hadoop.ozone.OzoneAcl;
+import org.apache.hadoop.ozone.client.OzoneClient;
+import org.apache.hadoop.ozone.security.acl.OzoneObj;
+import org.apache.hadoop.ozone.security.acl.OzoneObjInfo;
+import org.apache.hadoop.ozone.web.ozShell.Handler;
+import org.apache.hadoop.ozone.web.ozShell.OzoneAddress;
+import org.apache.hadoop.ozone.web.ozShell.Shell;
+import org.apache.hadoop.ozone.web.utils.JsonUtils;
+import picocli.CommandLine;
+import picocli.CommandLine.Command;
+import picocli.CommandLine.Parameters;
+
+import java.util.Objects;
+
+import static org.apache.hadoop.ozone.security.acl.OzoneObj.StoreType.OZONE;
+
+/**
+ * Executes Info bucket.
+ */
+@Command(name = "removeacl",
+    description = "Remove an acl.")
+public class RemoveAclBucketHandler extends Handler {
+
+  @Parameters(arity = "1..1", description = Shell.OZONE_BUCKET_URI_DESCRIPTION)
+  private String uri;
+
+  @CommandLine.Option(names = {"--acl", "-a"},
+      required = true,
+      description = "new acl." +
+          "r = READ," +
+          "w = WRITE," +
+          "c = CREATE," +
+          "d = DELETE," +
+          "l = LIST," +
+          "a = ALL," +
+          "n = NONE," +
+          "x = READ_AC," +
+          "y = WRITE_AC" +
+          "Ex user:user1:rw or group:hadoop:rw")
+  private String acl;
+
+  @CommandLine.Option(names = {"--store", "-s"},
+      required = false,
+      description = "store type. i.e OZONE or S3")
+  private String storeType;
+
+  /**
+   * Executes the Client Calls.
+   */
+  @Override
+  public Void call() throws Exception {
+    Objects.requireNonNull(acl, "New acl to be added not specified.");
+    OzoneAddress address = new OzoneAddress(uri);
+    address.ensureBucketAddress();
+    OzoneClient client = address.createClient(createOzoneConfiguration());
+
+    String volumeName = address.getVolumeName();
+    String bucketName = address.getBucketName();
+
+    if (isVerbose()) {
+      System.out.printf("Volume Name : %s%n", volumeName);
+      System.out.printf("Bucket Name : %s%n", bucketName);
+    }
+
+    OzoneObj obj = OzoneObjInfo.Builder.newBuilder()
+        .setBucketName(bucketName)
+        .setVolumeName(volumeName)
+        .setResType(OzoneObj.ResourceType.BUCKET)
+        .setStoreType(storeType == null ? OZONE :
+            OzoneObj.StoreType.valueOf(storeType))
+        .build();
+
+    boolean result = client.getObjectStore().removeAcl(obj,
+        OzoneAcl.parseAcl(acl));
+
+    System.out.printf("%s%n", JsonUtils.toJsonStringWithDefaultPrettyPrinter(
+        JsonUtils.toJsonString("Acl set successfully: " + result)));
 
 Review comment:
   done
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 256569)
    Time Spent: 3h 20m  (was: 3h 10m)

> Cli to add,remove,get and delete acls for Ozone objects
> -------------------------------------------------------
>
>                 Key: HDDS-1545
>                 URL: https://issues.apache.org/jira/browse/HDDS-1545
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Ajay Kumar
>            Assignee: Ajay Kumar
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> Update Ozone Cli to add,remove,get and delete acls for Ozone objects



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message