hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12487) FsDatasetSpi.isValidBlock() lacks null pointer check inside and neither do the callers
Date Tue, 25 Jun 2019 02:30:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16871934#comment-16871934

Hudson commented on HDFS-12487:

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #16818 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/16818/])
HDFS-14598. Findbugs warning caused by HDFS-12487. Contributed by He (aengineer: rev 041e7a7dee4a17714f31952dc6364c77a65b1b73)
* (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DiskBalancer.java

> FsDatasetSpi.isValidBlock() lacks null pointer check inside and neither do the callers
> --------------------------------------------------------------------------------------
>                 Key: HDFS-12487
>                 URL: https://issues.apache.org/jira/browse/HDFS-12487
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: balancer &amp; mover, diskbalancer
>    Affects Versions: 3.0.0
>         Environment: CentOS 6.8 x64
> CPU:4 core
> Memory:16GB
> Hadoop: Release 3.0.0-alpha4
>            Reporter: liumi
>            Assignee: liumi
>            Priority: Major
>             Fix For: 3.3.0, 3.2.1, 3.1.3
>         Attachments: HDFS-12487.002.patch, HDFS-12487.003.patch
>   Original Estimate: 0h
>  Remaining Estimate: 0h
> BlockIteratorImpl.nextBlock() will look for the blocks in the source volume, if there
are no blocks any more, it will return null up to DiskBalancer.getBlockToCopy(). However,
the DiskBalancer.getBlockToCopy() will check whether it's a valid block.
> When I look into the FsDatasetSpi.isValidBlock(), I find that it doesn't check the null
pointer! In fact, we firstly need to check whether it's null or not, or exception will occur.
> This bug is hard to find, because the DiskBalancer hardly copy all the data of one volume
to others. Even if some times we may copy all the data of one volume to other volumes, when
the bug occurs, the copy process has already done.
> However, when we try to copy all the data of two or more volumes to other volumes in
more than one step, the thread will be shut down, which is caused by the bug above.
> The bug can fixed by two ways:
> 1)Before the call of FsDatasetSpi.isValidBlock(), we check the null pointer
> 2)Check the null pointer inside the implementation of FsDatasetSpi.isValidBlock()

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message