From hdfs-issues-return-263565-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Mon May 20 16:48:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5A3E6180627 for ; Mon, 20 May 2019 18:48:03 +0200 (CEST) Received: (qmail 45218 invoked by uid 500); 20 May 2019 16:48:02 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 45198 invoked by uid 99); 20 May 2019 16:48:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 May 2019 16:48:02 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DF39DE2C59 for ; Mon, 20 May 2019 16:48:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6A32A25817 for ; Mon, 20 May 2019 16:48:00 +0000 (UTC) Date: Mon, 20 May 2019 16:48:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (HDDS-1406) Avoid usage of commonPool in RatisPipelineUtils MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDDS-1406?focusedWorklogId=3D2= 45307&page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpan= el#worklog-245307 ] ASF GitHub Bot logged work on HDDS-1406: ---------------------------------------- Author: ASF GitHub Bot Created on: 20/May/19 16:47 Start Date: 20/May/19 16:47 Worklog Time Spent: 10m=20 Work Description: lokeshj1703 commented on pull request #714: HDDS-14= 06. Avoid usage of commonPool in RatisPipelineUtils. URL: https://github.com/apache/hadoop/pull/714#discussion_r285681320 =20 =20 ########## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm= /pipeline/RatisPipelineProvider.java ########## @@ -133,7 +173,86 @@ public Pipeline create(ReplicationFactor factor, .build(); } =20 + + @Override + public void shutdown() { + forkJoinPool.shutdownNow(); =20 Review comment: @bharatviswa504 I agree. We need to use shutdownNow but we also need to = use awaitTermination. shutdownNow would interrupt the running tasks but the= running task should handle the interrupt. If the task does not exit on int= errupt, it is a better idea to wait for the task to finish. =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 245307) Time Spent: 10h 50m (was: 10h 40m) > Avoid usage of commonPool in RatisPipelineUtils > ----------------------------------------------- > > Key: HDDS-1406 > URL: https://issues.apache.org/jira/browse/HDDS-1406 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Reporter: Bharat Viswanadham > Assignee: Bharat Viswanadham > Priority: Major > Labels: pull-request-available > Time Spent: 10h 50m > Remaining Estimate: 0h > > We use parallelStream in during createPipline, this internally uses commo= nPool. Use Our own=C2=A0ForkJoinPool with parallelisim set with number of p= rocessors. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org