hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-1597) Remove hdds-server-scm dependency from ozone-common
Date Wed, 29 May 2019 14:39:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-1597?focusedWorklogId=250173&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-250173
]

ASF GitHub Bot logged work on HDDS-1597:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/May/19 14:38
            Start Date: 29/May/19 14:38
    Worklog Time Spent: 10m 
      Work Description: elek commented on pull request #860: HDDS-1597. Remove hdds-server-scm
dependency from ozone-common
URL: https://github.com/apache/hadoop/pull/860#discussion_r288602135
 
 

 ##########
 File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestKeyManagerImpl.java
 ##########
 @@ -52,6 +51,7 @@
 import org.apache.hadoop.test.GenericTestUtils;
 import org.apache.hadoop.test.LambdaTestUtils;
 
+import org.apache.commons.lang3.RandomStringUtils;
 
 Review comment:
   In this case this is not just a reorder because I replaced the original commons-lang2 transitive
dependency with commons-lang3 and the package name is different.
   
   But I agree, this is not a fair modification. Let's fix only the dependencies here and
don't include additional modification. I fixed it with using the original commons-lang2 (and
added the explicit dependency which was used from a transitive dependency until now).
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 250173)
    Time Spent: 1.5h  (was: 1h 20m)

> Remove hdds-server-scm dependency from ozone-common
> ---------------------------------------------------
>
>                 Key: HDDS-1597
>                 URL: https://issues.apache.org/jira/browse/HDDS-1597
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: ozone-dependency.png
>
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> I noticed that the hadoop-ozone/common project depends on hadoop-hdds-server-scm project.
> The common projects are designed to be a shared artifacts between client and server side.
Adding additional dependency to the common pom means that the dependency will be available
for all the clients as well.
> (See the attached artifact about the current, desired structure).
> We definitely don't need scm server dependency on the client side.
> The code dependency is just one class (ScmUtils) and the shared code can be easily moved
to the common.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message