hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-1579) Create OMDoubleBuffer metrics
Date Thu, 30 May 2019 19:15:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-1579?focusedWorklogId=251245&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-251245
]

ASF GitHub Bot logged work on HDDS-1579:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/May/19 19:14
            Start Date: 30/May/19 19:14
    Worklog Time Spent: 10m 
      Work Description: xiaoyuyao commented on pull request #871: HDDS-1579. Create OMDoubleBuffer
metrics.
URL: https://github.com/apache/hadoop/pull/871#discussion_r289132386
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerDoubleBuffer.java
 ##########
 @@ -134,6 +141,23 @@ private void flushTransactions() {
     }
   }
 
+  /**
+   * Set OzoneManagerDoubleBuffer metrics values.
+   * @param flushedTransactionsSize
+   */
+  private void setOzoneManagerDoubleBufferMetrics(
+      long flushedTransactionsSize) {
+    ozoneManagerDoubleBufferMetrics.incTotalNumOfFlushIterations();
+    ozoneManagerDoubleBufferMetrics.setTotalNumOfFlushedTransactions(
 
 Review comment:
   NIT: setTotalNumOfFlushedTransactions is confusing. Should we rename it to setTotalSizeOfFlushedTransactions
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 251245)
    Time Spent: 40m  (was: 0.5h)

> Create OMDoubleBuffer metrics
> -----------------------------
>
>                 Key: HDDS-1579
>                 URL: https://issues.apache.org/jira/browse/HDDS-1579
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> This Jira is to implement OMDoubleBuffer metrics, to show metrics like.
>  # flushIterations.
>  # totalTransactionsflushed.
>  
> Any other related metrics. This Jira is created based on the comment by [~anu] during
HDDS-1512 review.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message