hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-1555) Disable install snapshot for ContainerStateMachine
Date Thu, 23 May 2019 17:51:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-1555?focusedWorklogId=247589&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-247589
]

ASF GitHub Bot logged work on HDDS-1555:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/May/19 17:50
            Start Date: 23/May/19 17:50
    Worklog Time Spent: 10m 
      Work Description: swagle commented on pull request #846: HDDS-1555. Disable install
snapshot for ContainerStateMachine.
URL: https://github.com/apache/hadoop/pull/846#discussion_r287061991
 
 

 ##########
 File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/XceiverServerRatis.java
 ##########
 @@ -597,4 +603,12 @@ void handleNodeSlowness(RaftGroup group, RoleInfoProto roleInfoProto)
{
   void handleNoLeader(RaftGroup group, RoleInfoProto roleInfoProto) {
     handlePipelineFailure(group.getGroupId(), roleInfoProto);
   }
+
+  void handleInstallSnapshotFromLeader(RaftGroup group,
+      RoleInfoProto roleInfoProto, TermIndex firstTermIndexInLog) {
+    LOG.warn("Install snapshot notification received from Leader with " +
+        "termIndex : " + firstTermIndexInLog +
+        ", terminating pipeline " + group.getGroupId());
+    handlePipelineFailure(group.getGroupId(), roleInfoProto);
 
 Review comment:
   Yes sorry, let me add to the description.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 247589)
    Time Spent: 1h  (was: 50m)

> Disable install snapshot for ContainerStateMachine
> --------------------------------------------------
>
>                 Key: HDDS-1555
>                 URL: https://issues.apache.org/jira/browse/HDDS-1555
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: Ozone Datanode
>    Affects Versions: 0.3.0
>            Reporter: Mukul Kumar Singh
>            Assignee: Siddharth Wagle
>            Priority: Major
>              Labels: MiniOzoneChaosCluster, pull-request-available
>             Fix For: 0.5.0
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> In case a follower lags behind the leader by a large number, the leader tries to send
the snapshot to the follower. For ContainerStateMachine, the information in the snapshot it
not the entire state machine data. InstallSnapshot for ContainerStateMachine should be disabled.
> {code}
> 2019-05-19 10:58:22,198 WARN  server.GrpcLogAppender (GrpcLogAppender.java:installSnapshot(423))
- GrpcLogAppender(e3e19760-1340-4acd-b50d-f8a796a97254->28d9bd2f-3fe2-4a69-8120-757a00fa2f20):
failed to install snapshot [/Users/msingh/code/apache/ozone/github/git_oz_bugs_fixes/hadoop-ozone/integration-test/target/test/data/MiniOzoneClusterImpl-c2a863ef-8be9-445c-886f-57cad3a7b12e/datanode-6/data/ratis/fb88b749-3e75-4381-8973-6e0cb4904c7e/sm/snapshot.2_190]:
{}
> java.lang.NullPointerException
>         at org.apache.ratis.server.impl.LogAppender.readFileChunk(LogAppender.java:369)
>         at org.apache.ratis.server.impl.LogAppender.access$1100(LogAppender.java:54)
>         at org.apache.ratis.server.impl.LogAppender$SnapshotRequestIter$1.next(LogAppender.java:318)
>         at org.apache.ratis.server.impl.LogAppender$SnapshotRequestIter$1.next(LogAppender.java:303)
>         at org.apache.ratis.grpc.server.GrpcLogAppender.installSnapshot(GrpcLogAppender.java:412)
>         at org.apache.ratis.grpc.server.GrpcLogAppender.runAppenderImpl(GrpcLogAppender.java:101)
>         at org.apache.ratis.server.impl.LogAppender$AppenderDaemon.run(LogAppender.java:80)
>         at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message