hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-1512) Implement DoubleBuffer in OzoneManager
Date Mon, 20 May 2019 03:14:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-1512?focusedWorklogId=244756&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-244756
]

ASF GitHub Bot logged work on HDDS-1512:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/May/19 03:13
            Start Date: 20/May/19 03:13
    Worklog Time Spent: 10m 
      Work Description: arp7 commented on pull request #810: HDDS-1512. Implement DoubleBuffer
in OzoneManager.
URL: https://github.com/apache/hadoop/pull/810#discussion_r285418524
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/OMBucketCreateResponse.java
 ##########
 @@ -0,0 +1,52 @@
+/**
 
 Review comment:
   @bharatviswa504 why is this change a part of the DoubleBuffer patch? This patch should
just introduce the DoubleBuffer.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 244756)
    Time Spent: 3h 40m  (was: 3.5h)

> Implement DoubleBuffer in OzoneManager
> --------------------------------------
>
>                 Key: HDDS-1512
>                 URL: https://issues.apache.org/jira/browse/HDDS-1512
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>          Components: Ozone Manager
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> This Jira is created to implement DoubleBuffer in OzoneManager to flush transactions
to OM DB.
>  
> h2. Flushing Transactions to RocksDB:
> We propose using an implementation similar to the HDFS EditsDoubleBuffer.  We shall
flush RocksDB transactions in batches, instead of current way of using rocksdb.put() after
every operation. At a given time only one batch will be outstanding for flush while newer transactions
are accumulated in memory to be flushed later.
>  
> In DoubleBuffer it will have 2 buffers one is currentBuffer, and the other is readyBuffer.
We add entry to current buffer, and we check if another flush call is outstanding. If not,
we flush to disk Otherwise we add entries to otherBuffer while sync is happening.
>  
> In this if sync is happening, we shall add new requests to other buffer and when we can
sync we use *RocksDB batch commit to sync to disk, instead of rocksdb put.*
>  
> Note: If flush to disk is failed on any OM, we shall terminate the OzoneManager, so that
OM DB’s will not diverge. Flush failure should be considered as catastrophic failure.
>  
> Scope of this Jira is to add DoubleBuffer implementation, integrating to current OM will
be done in further jira's.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message