hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-1512) Implement DoubleBuffer in OzoneManager
Date Mon, 13 May 2019 20:44:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-1512?focusedWorklogId=241279&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-241279
]

ASF GitHub Bot logged work on HDDS-1512:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/May/19 20:43
            Start Date: 13/May/19 20:43
    Worklog Time Spent: 10m 
      Work Description: hadoop-yetus commented on issue #810: HDDS-1512. Implement DoubleBuffer
in OzoneManager.
URL: https://github.com/apache/hadoop/pull/810#issuecomment-491978630
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | 0 | reexec | 103 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. |
   ||| _ trunk Compile Tests _ |
   | +1 | mvninstall | 515 | trunk passed |
   | +1 | compile | 212 | trunk passed |
   | +1 | checkstyle | 53 | trunk passed |
   | +1 | mvnsite | 0 | trunk passed |
   | +1 | shadedclient | 896 | branch has no errors when building and testing our client artifacts.
|
   | +1 | javadoc | 130 | trunk passed |
   | 0 | spotbugs | 237 | Used deprecated FindBugs config; considering switching to SpotBugs.
|
   | +1 | findbugs | 433 | trunk passed |
   | -0 | patch | 264 | Used diff version of patch file. Binary files and potentially other
changes not applied. Please rebase and squash commits if necessary. |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 408 | the patch passed |
   | +1 | compile | 199 | the patch passed |
   | +1 | javac | 199 | the patch passed |
   | +1 | checkstyle | 54 | the patch passed |
   | +1 | mvnsite | 0 | the patch passed |
   | +1 | whitespace | 1 | The patch has no whitespace issues. |
   | +1 | shadedclient | 687 | patch has no errors when building and testing our client artifacts.
|
   | +1 | javadoc | 118 | the patch passed |
   | +1 | findbugs | 428 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 160 | hadoop-hdds in the patch failed. |
   | -1 | unit | 1794 | hadoop-ozone in the patch failed. |
   | +1 | asflicense | 43 | The patch does not generate ASF License warnings. |
   | | | 6309 | |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | hadoop.ozone.client.rpc.TestBlockOutputStream |
   |   | hadoop.ozone.client.rpc.TestContainerStateMachineFailures |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-810/4/artifact/out/Dockerfile
|
   | GITHUB PR | https://github.com/apache/hadoop/pull/810 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient
findbugs checkstyle |
   | uname | Linux 55df0f9aa4c8 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018
x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / 389e640 |
   | Default Java | 1.8.0_191 |
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-810/4/artifact/out/patch-unit-hadoop-hdds.txt
|
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-810/4/artifact/out/patch-unit-hadoop-ozone.txt
|
   |  Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-810/4/testReport/
|
   | Max. process+thread count | 5061 (vs. ulimit of 5500) |
   | modules | C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager |
   | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-810/4/console
|
   | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 241279)
    Time Spent: 40m  (was: 0.5h)

> Implement DoubleBuffer in OzoneManager
> --------------------------------------
>
>                 Key: HDDS-1512
>                 URL: https://issues.apache.org/jira/browse/HDDS-1512
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>          Components: Ozone Manager
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> This Jira is created to implement DoubleBuffer in OzoneManager to flush transactions
to OM DB.
>  
> h2. Flushing Transactions to RocksDB:
> We propose using an implementation similar to the HDFS EditsDoubleBuffer.  We shall
flush RocksDB transactions in batches, instead of current way of using rocksdb.put() after
every operation. At a given time only one batch will be outstanding for flush while newer transactions
are accumulated in memory to be flushed later.
>  
> In DoubleBuffer it will have 2 buffers one is currentBuffer, and the other is readyBuffer.
We add entry to current buffer, and we check if another flush call is outstanding. If not,
we flush to disk Otherwise we add entries to otherBuffer while sync is happening.
>  
> In this if sync is happening, we shall add new requests to other buffer and when we can
sync we use *RocksDB batch commit to sync to disk, instead of rocksdb put.*
>  
> Note: If flush to disk is failed on any OM, we shall terminate the OzoneManager, so that
OM DB’s will not diverge. Flush failure should be considered as catastrophic failure.
>  
> Scope of this Jira is to add DoubleBuffer implementation, integrating to current OM will
be done in further jira's.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message