hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ayush Saxena (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-14475) RBF: Expose router security enabled status on the UI
Date Fri, 10 May 2019 19:30:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837548#comment-16837548

Ayush Saxena commented on HDFS-14475:

Thanx [~crh] for the patch overall quite straight forward.
Minor nit ;
+   * Get the security status of the router.
+   *
+   * @return Security status.

The blank line can be avoided, guess only {{getRouterStatus()}} follows this trend all others
seems to be not. May be you can remove it if you plan to update.
Other than this LGTM

> RBF: Expose router security enabled status on the UI
> ----------------------------------------------------
>                 Key: HDFS-14475
>                 URL: https://issues.apache.org/jira/browse/HDFS-14475
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: CR Hota
>            Assignee: CR Hota
>            Priority: Major
>         Attachments: HDFS-14475-HDFS-13891.001.patch
> This is a branched off Jira to expose metric so that router's security status can be
displayed on the UI. We are still unclear if more work needs to be done for dealing with CORS
etc. https://issues.apache.org/jira/browse/HDFS-12510 will continue to track that.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message