hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Elek, Marton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDDS-1458) Create a maven profile to run fault injection tests
Date Thu, 30 May 2019 14:43:00 GMT

    [ https://issues.apache.org/jira/browse/HDDS-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851944#comment-16851944
] 

Elek, Marton commented on HDDS-1458:
------------------------------------

Thanks the update [~eyang] and I apologize if my previous comment was not clear enough.

Please keep all the docker-compose file of the dist package in the current form. If you think
it's better to *move* the compose/ozoneblockade to test/blockade/compose, I am fine with it,
but please don't modify the content (It was not modified at my previous review but it was
modified somewhere between the patch 10 and patch 12).

And please keep the original method to find the docker-compose files *as a default* option:

To be more precious:

I would suggest to use:

{code}
if "MAVEN_TEST" in os.environ:
  compose_dir = environ.get("MAVEN_TEST")
  FILE = os.path.join(compose_dir, "docker-compose.yaml")
elif "OZONE_HOME" in os.environ:
  compose_dir = environ.get("OZONE_HOME")
  FILE = os.path.join(compose_dir, "compose", "ozone", \
         "docker-compose.yaml")
else:
  parent_dir = os.path.dirname(os.path.dirname(os.path.realpath(__file__)))+  FILE = os.path.join(parent_dir,
"compose", "ozone", \
         "docker-compose.yaml")
{code}

Instead of

{code}
if "MAVEN_TEST" in os.environ:
  compose_dir = environ.get("MAVEN_TEST")
  FILE = os.path.join(compose_dir, "docker-compose.yaml")
elif "OZONE_HOME" in os.environ:
  compose_dir = environ.get("OZONE_HOME")
  FILE = os.path.join(compose_dir, "compose", "ozone", \
         "docker-compose.yaml")
else:
  compose_dir = os.getcwd()
  FILE = os.path.join(compose_dir, "compose", "ozone", \
         "docker-compose.yaml")
{code}

Because it's less error-prone. It's 100% compatible with the documentation but it enables
to run the blockade test from different dirs which help us to simplify CI jobs.

Thanks a lot.

> Create a maven profile to run fault injection tests
> ---------------------------------------------------
>
>                 Key: HDDS-1458
>                 URL: https://issues.apache.org/jira/browse/HDDS-1458
>             Project: Hadoop Distributed Data Store
>          Issue Type: Test
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.4.1
>
>         Attachments: HDDS-1458.001.patch, HDDS-1458.002.patch, HDDS-1458.003.patch, HDDS-1458.004.patch,
HDDS-1458.005.patch, HDDS-1458.006.patch, HDDS-1458.007.patch, HDDS-1458.008.patch, HDDS-1458.009.patch,
HDDS-1458.010.patch, HDDS-1458.011.patch, HDDS-1458.012.patch, HDDS-1458.013.patch, HDDS-1458.014.patch
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Some fault injection tests have been written using blockade.  It would be nice to have
ability to start docker compose and exercise the blockade test cases against Ozone docker
containers, and generate reports.  This is optional integration tests to catch race conditions
and fault tolerance defects. 
> We can introduce a profile with id: it (short for integration tests).  This will launch
docker compose via maven-exec-plugin and run blockade to simulate container failures and timeout.
> Usage command:
> {code}
> mvn clean verify -Pit
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message