hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-1406) Avoid usage of commonPool in RatisPipelineUtils
Date Mon, 20 May 2019 16:48:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-1406?focusedWorklogId=245307&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-245307
]

ASF GitHub Bot logged work on HDDS-1406:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/May/19 16:47
            Start Date: 20/May/19 16:47
    Worklog Time Spent: 10m 
      Work Description: lokeshj1703 commented on pull request #714: HDDS-1406. Avoid usage
of commonPool in RatisPipelineUtils.
URL: https://github.com/apache/hadoop/pull/714#discussion_r285681320
 
 

 ##########
 File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/RatisPipelineProvider.java
 ##########
 @@ -133,7 +173,86 @@ public Pipeline create(ReplicationFactor factor,
         .build();
   }
 
+
+  @Override
+  public void shutdown() {
+    forkJoinPool.shutdownNow();
 
 Review comment:
   @bharatviswa504 I agree. We need to use shutdownNow but we also need to use awaitTermination.
shutdownNow would interrupt the running tasks but the running task should handle the interrupt.
If the task does not exit on interrupt, it is a better idea to wait for the task to finish.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 245307)
    Time Spent: 10h 50m  (was: 10h 40m)

> Avoid usage of commonPool in RatisPipelineUtils
> -----------------------------------------------
>
>                 Key: HDDS-1406
>                 URL: https://issues.apache.org/jira/browse/HDDS-1406
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10h 50m
>  Remaining Estimate: 0h
>
> We use parallelStream in during createPipline, this internally uses commonPool. Use Our
own ForkJoinPool with parallelisim set with number of processors.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message