hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-1475) Fix OzoneContainer start method
Date Tue, 30 Apr 2019 22:21:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-1475?focusedWorklogId=235566&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-235566
]

ASF GitHub Bot logged work on HDDS-1475:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/Apr/19 22:20
            Start Date: 30/Apr/19 22:20
    Worklog Time Spent: 10m 
      Work Description: avijayanhwx commented on pull request #788: HDDS-1475 : Fix OzoneContainer
start method.
URL: https://github.com/apache/hadoop/pull/788#discussion_r279958400
 
 

 ##########
 File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/OzoneContainer.java
 ##########
 @@ -183,8 +183,12 @@ private void stopContainerScrub() {
   public void start(String scmId) throws IOException {
     LOG.info("Attempting to start container services.");
     startContainerScrub();
 
 Review comment:
   Added. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 235566)
    Time Spent: 50m  (was: 40m)

> Fix OzoneContainer start method
> -------------------------------
>
>                 Key: HDDS-1475
>                 URL: https://issues.apache.org/jira/browse/HDDS-1475
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: Ozone Datanode
>            Reporter: Bharat Viswanadham
>            Assignee: Aravindan Vijayan
>            Priority: Major
>              Labels: newbie, pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> In OzoneContainer start() we have 
> {code:java}
> startContainerScrub();
> writeChannel.start();
> readChannel.start();
> hddsDispatcher.init();
> hddsDispatcher.setScmId(scmId);{code}
>  
> Suppose here if readChannel.start() failed due to some reason, from VersionEndPointTask,
we try to start OzoneContainer again. This can cause an issue for writeChannel.start() if it
is already started. 
>  
> Fix the logic such a way that if service is started, don't attempt to start the service
again. Similar changes needed to be done for stop().



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message