hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-1406) Avoid usage of commonPool in RatisPipelineUtils
Date Thu, 11 Apr 2019 15:48:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-1406?focusedWorklogId=226094&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-226094
]

ASF GitHub Bot logged work on HDDS-1406:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Apr/19 15:47
            Start Date: 11/Apr/19 15:47
    Worklog Time Spent: 10m 
      Work Description: lokeshj1703 commented on pull request #714: HDDS-1406. Avoid usage
of commonPool in RatisPipelineUtils.
URL: https://github.com/apache/hadoop/pull/714#discussion_r274492733
 
 

 ##########
 File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/RatisPipelineUtils.java
 ##########
 @@ -146,18 +156,21 @@ private static void callRatisRpc(List<DatanodeDetails> datanodes,
         SecurityConfig(ozoneConf));
     final TimeDuration requestTimeout =
         RatisHelper.getClientRequestTimeout(ozoneConf);
-    datanodes.parallelStream().forEach(d -> {
-      final RaftPeer p = RatisHelper.toRaftPeer(d);
-      try (RaftClient client = RatisHelper
-          .newRaftClient(SupportedRpcType.valueOfIgnoreCase(rpcType), p,
-              retryPolicy, maxOutstandingRequests, tlsConfig, requestTimeout)) {
-        rpc.accept(client, p);
-      } catch (IOException ioe) {
-        String errMsg =
-            "Failed invoke Ratis rpc " + rpc + " for " + d.getUuid();
-        LOG.error(errMsg, ioe);
-        exceptions.add(new IOException(errMsg, ioe));
-      }
+    pool.submit(() -> {
 
 Review comment:
   I think we need to make submit call for each datanode.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 226094)
    Time Spent: 0.5h  (was: 20m)

> Avoid usage of commonPool in RatisPipelineUtils
> -----------------------------------------------
>
>                 Key: HDDS-1406
>                 URL: https://issues.apache.org/jira/browse/HDDS-1406
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> We use parallelStream in during createPipline, this internally uses commonPool. Use Our
own ForkJoinPool with parallelisim set with number of processors.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message