hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-1402) Remove unused ScmBlockLocationProtocol from ObjectStoreHandler
Date Fri, 12 Apr 2019 13:20:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-1402?focusedWorklogId=226655&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-226655
]

ASF GitHub Bot logged work on HDDS-1402:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Apr/19 13:19
            Start Date: 12/Apr/19 13:19
    Worklog Time Spent: 10m 
      Work Description: hadoop-yetus commented on issue #707: HDDS-1402. Remove unused ScmBlockLocationProtocol
from ObjectStoreHandler
URL: https://github.com/apache/hadoop/pull/707#issuecomment-482571528
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | 0 | reexec | 22 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -1 | test4tests | 0 | The patch doesn't appear to include any new or modified tests.
 Please justify why no new tests are needed for this patch. Also please list what manual steps
were performed to verify this patch. |
   ||| _ trunk Compile Tests _ |
   | +1 | mvninstall | 1181 | trunk passed |
   | +1 | compile | 50 | trunk passed |
   | +1 | checkstyle | 19 | trunk passed |
   | +1 | mvnsite | 28 | trunk passed |
   | +1 | shadedclient | 869 | branch has no errors when building and testing our client artifacts.
|
   | +1 | findbugs | 43 | trunk passed |
   | +1 | javadoc | 29 | trunk passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 51 | the patch passed |
   | +1 | compile | 22 | the patch passed |
   | +1 | javac | 22 | the patch passed |
   | +1 | checkstyle | 16 | the patch passed |
   | +1 | mvnsite | 26 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedclient | 1011 | patch has no errors when building and testing our client artifacts.
|
   | +1 | findbugs | 49 | the patch passed |
   | +1 | javadoc | 24 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 32 | objectstore-service in the patch passed. |
   | +1 | asflicense | 65 | The patch does not generate ASF License warnings. |
   | | | 3654 | |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-707/3/artifact/out/Dockerfile
|
   | GITHUB PR | https://github.com/apache/hadoop/pull/707 |
   | Optional Tests |  dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite 
unit  shadedclient  findbugs  checkstyle  |
   | uname | Linux b4a77c63e2e9 4.4.0-141-generic #167~14.04.1-Ubuntu SMP Mon Dec 10 13:20:24
UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / abace70 |
   | maven | version: Apache Maven 3.3.9 |
   | Default Java | 1.8.0_191 |
   | findbugs | v3.1.0-RC1 |
   |  Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-707/3/testReport/
|
   | Max. process+thread count | 295 (vs. ulimit of 5500) |
   | modules | C: hadoop-ozone/objectstore-service U: hadoop-ozone/objectstore-service |
   | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-707/3/console
|
   | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 226655)
    Time Spent: 1h  (was: 50m)

> Remove unused ScmBlockLocationProtocol from ObjectStoreHandler
> --------------------------------------------------------------
>
>                 Key: HDDS-1402
>                 URL: https://issues.apache.org/jira/browse/HDDS-1402
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> When I analyzed the usages of the available RPC protocols in Ozone I found that the ScmBlockLocationProtocol
is not used in ObjectStore at all.
> I would propose to remove it...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message