hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12245) Fix INodeId javadoc
Date Thu, 11 Apr 2019 01:17:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814988#comment-16814988
] 

Hudson commented on HDFS-12245:
-------------------------------

FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #16381 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/16381/])
HDFS-12245. Fix INodeId javadoc (aajisaka: rev 586826fe99038d4fcfa07a8a9a6b19cdf301aaf7)
* (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeId.java


> Fix INodeId javadoc
> -------------------
>
>                 Key: HDFS-12245
>                 URL: https://issues.apache.org/jira/browse/HDFS-12245
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: documentation, namenode
>            Reporter: Wei-Chiu Chuang
>            Assignee: Adam Antal
>            Priority: Major
>             Fix For: 3.3.0
>
>         Attachments: HDFS-12245.001.patch, HDFS-12245.002.patch, HDFS-12245.003.patch,
HDFS-12245.004.patch
>
>
> The INodeId javadoc states that id 1 to 1000 is reserved and root inode id start from
1001. That is no longer true after HDFS-4434.
> Also, it's a little weird in INodeId
> {code}
>   public static final long LAST_RESERVED_ID = 2 << 14 - 1;
>   public static final long ROOT_INODE_ID = LAST_RESERVED_ID + 1;
> {code}
> It seems the intent was for LAST_RESERVED_ID to be (2^14) - 1 = 32767. But due to Java
operator precedence, LAST_RESERVED_ID = 2^(14-1) = 16384. Maybe it doesn't matter, not sure.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message