From hdfs-issues-return-256187-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Wed Mar 13 06:34:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0673D18064A for ; Wed, 13 Mar 2019 07:34:03 +0100 (CET) Received: (qmail 45619 invoked by uid 500); 13 Mar 2019 06:34:02 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 45608 invoked by uid 99); 13 Mar 2019 06:34:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Mar 2019 06:34:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 2F3A3C96F2 for ; Wed, 13 Mar 2019 06:34:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 9M8i052PIsqu for ; Wed, 13 Mar 2019 06:34:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id BB2795F18F for ; Wed, 13 Mar 2019 06:34:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 56053E0144 for ; Wed, 13 Mar 2019 06:34:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 161DD24597 for ; Wed, 13 Mar 2019 06:34:00 +0000 (UTC) Date: Wed, 13 Mar 2019 06:34:00 +0000 (UTC) From: "Guo Lei (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-14367) Useless parameter maxPoolSize in striped reconstruct thread pool MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-14367?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:all-tabpanel ] Guo Lei updated HDFS-14367: --------------------------- Description:=20 The workQueue length wasn't specified, so the thread number never be increa= se. The thread number increase to=C2=A0maximumPoolSize only when the workQueue = is full. org/apache/hadoop/hdfs/server/datanode/erasurecode/ErasureCodingWorker.java private void initializeStripedBlkReconstructionThreadPool(int numThreads) { =C2=A0 LOG.debug("Using striped block reconstruction; pool threads=3D{}", =C2=A0 =C2=A0 =C2=A0 numThreads); =C2=A0 stripedReconstructionPool =3D DFSUtilClient.getThreadPoolExecutor(2= , =C2=A0 =C2=A0 =C2=A0 {color:#ff0000}numThreads{color}, 60, {color:#FF0000}= new LinkedBlockingQueue<>(){color}, =C2=A0 =C2=A0 =C2=A0 "StripedBlockReconstruction-", false); =C2=A0 stripedReconstructionPool.allowCoreThreadTimeOut(true); } was: The thread number increase to=C2=A0maximumPoolSize only when the workQueue = is full. org/apache/hadoop/hdfs/server/datanode/erasurecode/ErasureCodingWorker.java private void initializeStripedBlkReconstructionThreadPool(int numThreads) { =C2=A0 LOG.debug("Using striped block reconstruction; pool threads=3D{}", =C2=A0 =C2=A0 =C2=A0 numThreads); =C2=A0 stripedReconstructionPool =3D DFSUtilClient.getThreadPoolExecutor(2= , =C2=A0 =C2=A0 =C2=A0 {color:#FF0000}numThreads{color}, 60, new LinkedBlock= ingQueue<>(), =C2=A0 =C2=A0 =C2=A0 "StripedBlockReconstruction-", false); =C2=A0 stripedReconstructionPool.allowCoreThreadTimeOut(true); } > Useless parameter maxPoolSize in striped reconstruct thread pool > ---------------------------------------------------------------- > > Key: HDFS-14367 > URL: https://issues.apache.org/jira/browse/HDFS-14367 > Project: Hadoop HDFS > Issue Type: Bug > Components: ec > Affects Versions: 3.3.0 > Reporter: Guo Lei > Priority: Major > > The workQueue length wasn't specified, so the thread number never be incr= ease. > The thread number increase to=C2=A0maximumPoolSize only when the workQueu= e is full. > org/apache/hadoop/hdfs/server/datanode/erasurecode/ErasureCodingWorker.ja= va > private void initializeStripedBlkReconstructionThreadPool(int numThreads)= { > =C2=A0 LOG.debug("Using striped block reconstruction; pool threads=3D{}"= , > =C2=A0 =C2=A0 =C2=A0 numThreads); > =C2=A0 stripedReconstructionPool =3D DFSUtilClient.getThreadPoolExecutor= (2, > =C2=A0 =C2=A0 =C2=A0 {color:#ff0000}numThreads{color}, 60, {color:#FF000= 0}new LinkedBlockingQueue<>(){color}, > =C2=A0 =C2=A0 =C2=A0 "StripedBlockReconstruction-", false); > =C2=A0 stripedReconstructionPool.allowCoreThreadTimeOut(true); > } -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org