hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uma Maheswara Rao G (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-14393) Move stats related methods to MappableBlockLoader
Date Wed, 27 Mar 2019 23:30:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-14393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16803460#comment-16803460
] 

Uma Maheswara Rao G commented on HDFS-14393:
--------------------------------------------

[~rakeshr] Thanks for the refactoring.

Mostly patch looks good except the following.

MemoryVolumeManager: I don't think we have any volume for DRAM based cache. So, why do we
need to call as VolumeManager?
Instead should we say MemoryCacheStats ? you could also keep this as inner class to MemoryMappableBlockLoader
?

> Move stats related methods to MappableBlockLoader
> -------------------------------------------------
>
>                 Key: HDFS-14393
>                 URL: https://issues.apache.org/jira/browse/HDFS-14393
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>            Priority: Major
>         Attachments: HDFS-14393-001.patch
>
>
> This jira sub-task is to move stats related methods to specific loader and make FsDatasetCache
more cleaner to plugin DRAM and PMem implementations.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message