hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guo Lei (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-14367) Useless parameter maxPoolSize in striped reconstruct thread pool
Date Wed, 13 Mar 2019 06:34:00 GMT

     [ https://issues.apache.org/jira/browse/HDFS-14367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Guo Lei updated HDFS-14367:
---------------------------
    Description: 
The workQueue length wasn't specified, so the thread number never be increase.

The thread number increase to maximumPoolSize only when the workQueue is full.

org/apache/hadoop/hdfs/server/datanode/erasurecode/ErasureCodingWorker.java

private void initializeStripedBlkReconstructionThreadPool(int numThreads) {
   LOG.debug("Using striped block reconstruction; pool threads={}",
       numThreads);
   stripedReconstructionPool = DFSUtilClient.getThreadPoolExecutor(2,
       {color:#ff0000}numThreads{color}, 60, {color:#FF0000}new LinkedBlockingQueue<>(){color},
       "StripedBlockReconstruction-", false);
   stripedReconstructionPool.allowCoreThreadTimeOut(true);
 }

  was:
The thread number increase to maximumPoolSize only when the workQueue is full.

org/apache/hadoop/hdfs/server/datanode/erasurecode/ErasureCodingWorker.java

private void initializeStripedBlkReconstructionThreadPool(int numThreads) {
   LOG.debug("Using striped block reconstruction; pool threads={}",
       numThreads);
   stripedReconstructionPool = DFSUtilClient.getThreadPoolExecutor(2,
       {color:#FF0000}numThreads{color}, 60, new LinkedBlockingQueue<>(),
       "StripedBlockReconstruction-", false);
   stripedReconstructionPool.allowCoreThreadTimeOut(true);
 }


> Useless parameter maxPoolSize in striped reconstruct thread pool
> ----------------------------------------------------------------
>
>                 Key: HDFS-14367
>                 URL: https://issues.apache.org/jira/browse/HDFS-14367
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: ec
>    Affects Versions: 3.3.0
>            Reporter: Guo Lei
>            Priority: Major
>
> The workQueue length wasn't specified, so the thread number never be increase.
> The thread number increase to maximumPoolSize only when the workQueue is full.
> org/apache/hadoop/hdfs/server/datanode/erasurecode/ErasureCodingWorker.java
> private void initializeStripedBlkReconstructionThreadPool(int numThreads) {
>    LOG.debug("Using striped block reconstruction; pool threads={}",
>        numThreads);
>    stripedReconstructionPool = DFSUtilClient.getThreadPoolExecutor(2,
>        {color:#ff0000}numThreads{color}, 60, {color:#FF0000}new LinkedBlockingQueue<>(){color},
>        "StripedBlockReconstruction-", false);
>    stripedReconstructionPool.allowCoreThreadTimeOut(true);
>  }



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message