hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yiqun Lin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDDS-1233) Create an Ozone Manager Service provider for Recon.
Date Fri, 15 Mar 2019 08:06:00 GMT

    [ https://issues.apache.org/jira/browse/HDDS-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16793435#comment-16793435
] 

Yiqun Lin commented on HDDS-1233:
---------------------------------

Thanks for working on this, [~avijayan]. Almost looks good to me, some additional comments:

*OzoneManagerServiceProviderImpl*
 Line 98: Format string lacks one '{}'.
 Line 78: We can make these time configs support with time-unit suffixes. Like {{ozone.om.save.metrics.interval}}
did. After that, we should use {{Configuration#getTimeDuration}} to get the value.

*ReconOMHelper*
 Line 215: The GzipCompressorInputStream should be closed before throwing the exception, otherwise
it will lead the resource leak.

*OMConfigKeys*
 Line 56: This setting is existed in {{OzoneConfigKeys#OZONE_SECURITY_ENABLED_KEY}} under
hadoop-hdds-common.

*Unit test*
 Can we add the prefix '{{test'}}for all added test cases (exclude setup/teardown method)?
E.g. {{getOMMetadataManagerInstance}} to {{testGetOMMetadataManagerInstance}}.

> Create an Ozone Manager Service provider for Recon.
> ---------------------------------------------------
>
>                 Key: HDDS-1233
>                 URL: https://issues.apache.org/jira/browse/HDDS-1233
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>          Components: Ozone Recon
>            Reporter: Aravindan Vijayan
>            Assignee: Aravindan Vijayan
>            Priority: Major
>             Fix For: 0.5.0
>
>         Attachments: HDDS-1233-000.patch, HDDS-1233-001.patch
>
>
> * Implement an abstraction to let Recon make OM specific requests.
> * At this point of time, the only request is to get the DB snapshot. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message