hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-14340) Lower the log level when can't get postOpAttr
Date Thu, 07 Mar 2019 07:41:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-14340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786481#comment-16786481
] 

Hadoop QA commented on HDFS-14340:
----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  0s{color} | {color:blue}
Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  6s{color} | {color:red}
HDFS-14340 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HDFS-14340 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12961517/HDFS-14340.patch
|
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/26422/console |
| Powered by | Apache Yetus 0.8.0   http://yetus.apache.org |


This message was automatically generated.



> Lower the log level when can't get postOpAttr
> ---------------------------------------------
>
>                 Key: HDFS-14340
>                 URL: https://issues.apache.org/jira/browse/HDFS-14340
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: nfs
>    Affects Versions: 3.1.0, 2.8.5
>            Reporter: Anuhan Torgonshar
>            Priority: Major
>              Labels: easyfix
>         Attachments: HDFS-14340.patch
>
>
> I think should lower the log level when can't get postOpAttr in _*hadoop-2.8.5-src/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/**RpcProgramNfs3.java*_. 
>  
> {code:java}
> **************The fisrt code snippet***************
> //the problematic log level ERROR, at line 1044
> try {
>    dirWcc = Nfs3Utils.createWccData(Nfs3Utils.getWccAttr(preOpDirAttr),
>    dfsClient, dirFileIdPath, iug);
> } catch (IOException e1) {
>    LOG.error("Can't get postOpDirAttr for dirFileId: "
>    + dirHandle.getFileId(), e1);
> }
> **************The second code snippet***************
> //other practice in similar code snippets, line number is 475, the log assigned with
INFO level
> try { 
>    wccData = Nfs3Utils.createWccData(Nfs3Utils.getWccAttr(preOpAttr), dfsClient,   fileIdPath,
iug); 
> } catch (IOException e1) { 
>    LOG.info("Can't get postOpAttr for fileIdPath: " + fileIdPath, e1); 
> }
> **************The third code snippet***************
> //other practice in similar code snippets, line number is 1405, the log assigned with
INFO level
> try {
>    fromDirWcc = Nfs3Utils.createWccData(
>    Nfs3Utils.getWccAttr(fromPreOpAttr), dfsClient, fromDirFileIdPath,iug);
>    toDirWcc = Nfs3Utils.createWccData(Nfs3Utils.getWccAttr(toPreOpAttr),
>    dfsClient, toDirFileIdPath, iug);
> } catch (IOException e1) {
>    LOG.info("Can't get postOpDirAttr for " + fromDirFileIdPath + " or"
>    + toDirFileIdPath, e1);
> }
> {code}
> Therefore, I think the logging practices should be consistent in similar contexts. When
the code catches _*IOException*_ for *_getWccAttr()_* method, it more likely prints a log
message with _*INFO*_ level, a lower level.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message