hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HDDS-1217) Refactor ChillMode rules and chillmode manager
Date Thu, 07 Mar 2019 02:56:00 GMT

     [ https://issues.apache.org/jira/browse/HDDS-1217?focusedWorklogId=209320&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-209320
]

ASF GitHub Bot logged work on HDDS-1217:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Mar/19 02:55
            Start Date: 07/Mar/19 02:55
    Worklog Time Spent: 10m 
      Work Description: swagle commented on pull request #558: HDDS-1217. Refactor ChillMode
rules and chillmode manager.
URL: https://github.com/apache/hadoop/pull/558#discussion_r263219972
 
 

 ##########
 File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/chillmode/ChillModeExitRule.java
 ##########
 @@ -17,16 +17,79 @@
  */
 package org.apache.hadoop.hdds.scm.chillmode;
 
+import org.apache.hadoop.hdds.server.events.EventHandler;
+import org.apache.hadoop.hdds.server.events.EventPublisher;
+
+
 /**
- * Interface for defining chill mode exit rules.
+ * Abstract class for ChillModeExitRules. When a new rule is added, the new
+ * rule should extend this abstract class.
+ *
+ * Each rule Should do:
+ * 1. Should add a handler for the event it is looking for during the
+ * initialization of the rule.
+ * 2. Add the rule in ScmChillModeManager to list of the rules.
+ *
  *
  * @param <T>
  */
-public interface ChillModeExitRule<T> {
 
 Review comment:
   Just food for thought: You could actually still keep this as an interface and provide a
default implementation for onMessage. New Java 8 contract change that avoids introducing inheritance
purely for a default impl. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 209320)
    Time Spent: 50m  (was: 40m)

> Refactor ChillMode rules and chillmode manager
> ----------------------------------------------
>
>                 Key: HDDS-1217
>                 URL: https://issues.apache.org/jira/browse/HDDS-1217
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> # Make the chillmodeExitRule abstract class and move common logic for all rules into
this.
>  # Update test's for chill mode accordingly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message